-
Notifications
You must be signed in to change notification settings - Fork 215
perf: drawer style #1805
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: drawer style #1805
Conversation
<n-upload-file-list /> | ||
</n-upload> | ||
</n-flex> | ||
</template> | ||
</n-card> | ||
</n-flex> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is all text in Markdown.
It appears there may be some differences between the current line of code and what is referenced, but no major abnormalities or potential issues were found. If more specific information about the original piece of code is provided, I'd have to examine it further to ensure accuracy, especially given its date range. For any optimizations or suggested improvements not included here, such as performance tuning, efficiency increases, etc., additional context would be necessary for these aspects.
@@ -201,8 +212,6 @@ onUnmounted(() => { | |||
/> | |||
</n-tab-pane> | |||
</n-tabs> | |||
|
|||
<X class="absolute top-[28px] right-[1.25rem] cursor-pointer" :size="18" @click="closeDrawer" /> | |||
</n-drawer-content> | |||
</n-drawer> | |||
</template> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There doesn't seem to be anything specific that needs to be noted. However, I'll make some general recommendations:
- Ensure clear and consistent style guidelines are followed across the codebase
- Proper separation of concerns can avoid duplication of styles throughout the application
- Regularly review component design decisions to ensure they meet user goals
@@ -761,4 +763,5 @@ export function unloadListeners() { | |||
mittBus.off('file-upload'); | |||
mittBus.off('file-manage'); | |||
mittBus.off('stop-upload'); | |||
mittBus.off('upload-stopped'); | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code seems to be free of inconsistencies; however, here is a brief suggestion on potential improvement:
- Use 'let' instead of 'var' where there can exist multiple instances since it's only used once and declared block-level.
- Import necessary packages before they're needed. In this case, since
interrraptUpload
doesn't seem to import anything else, consider using ES modules if you are dealing with third-party libraries that need access in both the module namespace and global context.
Here's how the corrected code looks after these suggestions:
export function useFileManage(token: string, t: any) {
const sockets = [];
- let mittBus;
mittBus.on('stop-upload', data => intsrpretUpload(data));
return socket;
}
Please keep in mind that JavaScript is dynamically typed, so some type checking might not apply unless the exact types of variables have been explicitly specified elsewhere.
|
perf: drawer style