Fixes and features #201

MagiusCHE · 2021-12-15T14:36:52Z

Done

Better client injector method focused to separate js and css files to maintenance (suggeted by @joax but i think mine is a better solution in our case).
Integrated some features from @joax
- JS and CSS Injected into child windows 8c91e9b
- added unreadMessage observer handler mentioned by @joax as alternative handler (see next)
Added multiple handler for unreadMessage observer to handle custom urls be7307b
Fix Require is not defined #189, Notifications doesn't work on KDE Plasma #135
New feature: context menu cut/paste/etc... Fix No right click in message body #173
New feature: context menu Show link url, Copy link url, Copy link label. [ Feature Request ] Showing the actual link address when hovering the pointer over links #122

From ORIGIN

Merge from Julian

…ound (plasma is ignoring tray "click" event).

…nimized; fix settings.getSync default

…e moment.

…nstream.

…require works again.

…again.

Merge on main stream

…: true to let "require" workson client side.

…o load, cache and inject them.

…ng actions.

…ed link url

src/controller/mail-window-controller.js

MagiusCHE · 2021-12-17T09:28:30Z

We should ignore lift warning if we accept and need to use require at client side.

…ere electron/electron#31152

cavemandaveman · 2022-02-23T15:29:15Z

Any chance of this getting merged?

julian-alarcon

Hi! I appreciate your contributions! BTW it will be easier to review small PR for the next time.

Julian Alarcon and others added 29 commits October 26, 2020 11:48

Renamed mater to main branch

c092aa9

Merge branch 'main' of github.com:julian-alarcon/prospect-mail into main

26276ba

Fix author name in package.json (removed space)

06a7ad6

Merge pull request #2 from julian-alarcon/develop

7f82d50

From ORIGIN

Merge pull request #4 from julian-alarcon/main

db4ebb5

Merge from Julian

Merge branch 'main' of https://github.com/MagiusCHE/prospect-mail

0255561

Added "Show" to Tray menu to force show window and bring it to foregr…

463804b

…ound (plasma is ignoring tray "click" event).

julian-alarcon#193 parse --minimized via commandline to start app mi…

6aad71d

…nimized; fix settings.getSync default

resolved package.json conflict

e4f6bb2

Fixed trymenu broken setting. Note: hideOnMinimize doesn't work at th…

76d2708

…e moment.

fix window-controlled require electron to match recent changed in mai…

20f8e94

…nstream.

Merge on mainstream

1ff50f7

fix package json about-window requirement

b5d9422

julian-alarcon#189 Force nodeIntegration and contextIsolation to let …

f92b7f4

…require works again.

Merge branch 'main' into main

4e236e8

Undo Force nodeIntegration and contextIsolation to let require works …

2bd23ae

…again.

Merge branch 'main' of https://github.com/MagiusCHE/prospect-mail

156785d

Added minimize option on README

19af13c

Merge pull request #6 from julian-alarcon/main

5e2fb3f

Merge on main stream

Merge branch 'julian-alarcon:main' into main

a5c961a

fix package.json doubled lines

1c7cc5c

julian-alarcon#189 forced contextIsolation: false and nodeIntegration…

47cdf2a

…: true to let "require" workson client side.

UnreadNumberObserver is now in a separated js file

32c91ad

UnreadNumberObserver is now in a separated js file fix performance cache

dc2d03d

UnreadNumberObserver better tassonomy

692c6b7

client js and css are now in a separated file. Using clientInjector t…

e657373

…o load, cache and inject them.

Multiple unreadMessageObserver handler.

be7307b

Integrated did-create-window and child-window.js suggested by @joax

8c91e9b

Better client injector strategy. Moved all clinet files into /public dir

0ccc479

MagiusCHE requested a review from julian-alarcon as a code owner December 15, 2021 14:36

MagiusCHE changed the title ~~Fix and new fratures~~ Fixes and new features Dec 15, 2021

MagiusCHE changed the title ~~Fixes and new features~~ Fixes and features Dec 15, 2021

This was referenced Dec 15, 2021

[ Feature Request ] Showing the actual link address when hovering the pointer over links #122

Closed

No right click in message body #173

Closed

MagiusCHE added 3 commits December 15, 2021 21:32

julian-alarcon#122, julian-alarcon#173 Added context menu wilth Editi…

aa43e40

…ng actions.

julian-alarcon#122 Context menu will show first 50 chars of the click…

d3f1652

…ed link url

context-menu: undo will appear only on editable element.

33d359c

sonatype-lift bot reviewed Dec 16, 2021

View reviewed changes

src/controller/mail-window-controller.js Show resolved Hide resolved

sonatype-lift bot reviewed Dec 16, 2021

View reviewed changes

src/controller/mail-window-controller.js Show resolved Hide resolved

PeterMaltby mentioned this pull request Dec 22, 2021

No meeting / calendar / reminders notifications #192

Open

MagiusCHE added 6 commits January 21, 2022 12:54

try fix clear unreadmessageicon in some cases OWA

7a2e453

unread-observer "custom_2": attempting to be multilanguage

7ef80ee

#10 fixed Right click on child windows.

752e241

#10 fixed Right click on child windows.

f6fc4ed

update electron to "^16.0.5" in order to fix annoying bug described h…

58a6e11

…ere electron/electron#31152

update electron to "^16.0.9" in order to fix annoying bug described h…

adf3a42

…ere electron/electron#31152

julian-alarcon approved these changes Jul 24, 2023

View reviewed changes

julian-alarcon merged commit d3f474a into julian-alarcon:main Jul 24, 2023

julian-alarcon mentioned this pull request Sep 20, 2023

Release/0.5.0 #288

Merged

This was referenced Jun 6, 2025

[Feature Request]: choose nodeIntegration value in settings #312

Open

[Bug]: Duo Authentication Box Does Not Appear #299

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fixes and features #201

Fixes and features #201

Uh oh!

MagiusCHE commented Dec 15, 2021 •

edited by julian-alarcon

Loading

Uh oh!

Uh oh!

Uh oh!

MagiusCHE commented Dec 17, 2021

Uh oh!

cavemandaveman commented Feb 23, 2022

Uh oh!

julian-alarcon left a comment

Uh oh!

Uh oh!

Uh oh!

Fixes and features #201

Fixes and features #201

Uh oh!

Conversation

MagiusCHE commented Dec 15, 2021 • edited by julian-alarcon Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Done

Uh oh!

Uh oh!

Uh oh!

MagiusCHE commented Dec 17, 2021

Uh oh!

cavemandaveman commented Feb 23, 2022

Uh oh!

julian-alarcon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MagiusCHE commented Dec 15, 2021 •

edited by julian-alarcon

Loading