julec: fix help function to print formatted string #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamperkowski
approved these changes
Dec 16, 2024
|
You, as a member, don't have to fork the repo. You should be able to create a branch. |
mertcandav
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
In the earlier versions of the strings::Builder it supports Str function, which is called automatically by the print and println functions if defined like fn Str(self): str.
But it defined as fn Str(mut self): str currently and I don't think we should make it compatible for auto-call variant. It should be mutable due to behavior. This is not a typical Str conversion method.
So we have to call the Str method. Your fix is works as expected.
Thanks for your contribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed incorrect behavior of the help function for julec.
Checklist
Screenshots (if any)
Note to reviewers