Skip to content

Conversation

howbazaar
Copy link
Contributor

Forward port of #11585.

howbazaar and others added 3 commits May 15, 2020 15:40
Having the other side of the websocket go away isn't an error.
We now check to see if the error is a close error type, and if
it is, just log at trace. Only log an error if there is some other
error type.

Also had the pubsub handler use a more detailed logger for writing
errors so they can be filtered more easily.
juju#11585

Having the other side of the websocket go away isn't an error.
We now check to see if the error is a close error type, and if
it is, just log at trace. Only log an error if there is some other
error type.

Also had the pubsub handler use a more detailed logger for writing
errors so they can be filtered more easily.

## QA steps

```sh
# bootstrap and enable-ha
juju switch controller
juju model-config logging-config=juju=WARN:juju.apiserver.pubsub=TRACE
# in one window
juju debug-log
# in another window
juju ssh 2
sudo service jujud-machine-2 stop
```
Observe in the log that we get a "websocket closed" log line, not an error.

## Bug reference

https://bugs.launchpad.net/juju/+bug/1759372
Copy link
Contributor

@pengale pengale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (just a forward port of already approved pr.)

@howbazaar
Copy link
Contributor Author

$$merge$$

@jujubot jujubot merged commit 6d128f2 into juju:2.8-rc May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants