Skip to content

Backport Multiwatcher Unsafe Pointer Conversion Fix #11597

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 18, 2020
Merged

Backport Multiwatcher Unsafe Pointer Conversion Fix #11597

merged 1 commit into from
May 18, 2020

Conversation

manadart
Copy link
Member

Backports #11596 from develop, which fixes unsafe pointer conversion used in multi-watcher tests.

@manadart
Works around unsafe pointer conversion used in multi-watcher test to
dce3d43 
shim out concrete *state.StatePool.

This unsafe pointer conversion causes Go 1.14's checkptr to raise panics
in the race test suite.
@manadart
Copy link
Member Author

$$merge$$

1 similar comment
@manadart
Copy link
Member Author

$$merge$$

@jujubot jujubot merged commit e5d0efd into juju:2.8 May 18, 2020
@manadart manadart deleted the backport-unsafe-ptr-fix branch May 19, 2020 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonRichardson SimonRichardson SimonRichardson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@manadart @SimonRichardson @jujubot