Skip to content

Conversation

piyoki
Copy link
Contributor

@piyoki piyoki commented Aug 1, 2023

Background

Make use of golang-ci-lint to harden code quality. Introduce linting workflow and fix some existing warns/errors in the code base.

Note
Adding ci-lint is a good way to enforce quality check to contributors that are outside of @juicity.

Checklist

Full changelogs

  • ci: add linting workflow
  • fix: fix linting warns/errors

Issue reference

NA

Test Result

https://github.com/juicity/juicity/actions/runs/5727695886

image

@juicity-bot
Copy link
Contributor

juicity-bot bot commented Aug 1, 2023

❌ Your branch is currently out-of-sync to main. No worry, I will fix it for you.

mzz2017
mzz2017 previously approved these changes Aug 1, 2023
Copy link
Contributor

@mzz2017 mzz2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@piyoki piyoki requested a review from mzz2017 August 2, 2023 02:24
@piyoki piyoki requested a review from mzz2017 August 2, 2023 03:59
Copy link
Contributor

@mzz2017 mzz2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@piyoki piyoki merged commit bb8c0ff into main Aug 2, 2023
@piyoki piyoki deleted the golang-ci-lint branch August 2, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants