Drkey port pr6 #12
Merged
Drkey port pr6 #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juagargi
approved these changes
May 20, 2020
There was a problem hiding this comment.
just needs rebase.
Reviewed 3 of 5 files at r1, 2 of 2 files at r2, 3 of 4 files at r3, 1 of 1 files at r4, 4 of 4 files at r5.
Reviewable status:complete! all files reviewed, all discussions resolved
refactoring includes: - Renaming DRKey functions in messenger.go - Adapting logging to scionproto#3544
122c31d to
ca1cc93
Compare
juagargi
approved these changes
May 20, 2020
There was a problem hiding this comment.
Reviewed 1 of 1 files at r7, 4 of 4 files at r8.
Reviewable status:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
6th PR among several in order to port drkey feature to scionlab. Most of the features were first introduced in netsec-ethz#63.
Drkey feature in go/lib/infra.
Some minor changes:
This change is