#982 Fix for undesirable use of TextColumns as String Columns when slices are converted back to tables. #984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lwhite1
added a commit
that referenced
this pull request
Sep 4, 2021
lwhite1
added a commit
that referenced
this pull request
Sep 4, 2021
* Revert "#982 Fix for undesirable use of TextColumns as String Columns when slices are converted back to tables. (#984)" This reverts commit 8d07c4a. * replace poor handling of text columns in TableSliceGroup The original handling approach (converting them to string column) causes problems, including possibly exploding memory requirements. The new approach works directly with text columns when used to split a table, while retaining the old handling when using other column types, as it is more efficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing.
Description
StandardTableSliceGroups create tableSlices that can be reconverted to Tables with structures matching the original
Testing
Did you add a unit test? Yes