Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: j-hui/fidget.nvim
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.4.1
Choose a base ref
...
head repository: j-hui/fidget.nvim
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.4.2
Choose a head ref
  • 4 commits
  • 4 files changed
  • 3 contributors

Commits on May 18, 2024

  1. fix: trigger luarocks workflow on release

    This workflow was never triggering in the first place, leading to the
    issue encountered in #234.
    
    I suspect it is because triggering on the "created" event doesn't work.
    According to [documentation][release-trigger], "created" isn't triggered
    when draft releases are created. Not really sure how "Release Please"
    works but maybe it's creating a temporary draft before publishing?
    
    In any case, triggering on "published" seems to be what we're actually
    after in this case. Not 100% sure this fix will work but we shall see
    next time I bump the version.
    
    [release-trigger]: https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release
    j-hui committed May 18, 2024
    Configuration menu
    Copy the full SHA
    c4762f2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    275525b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    eb5179e View commit details
    Browse the repository at this point in the history
  4. chore(main): release 1.4.2 (#235)

    Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
    github-actions[bot] authored May 18, 2024
    Configuration menu
    Copy the full SHA
    0767f36 View commit details
    Browse the repository at this point in the history
Loading