This repository was archived by the owner on Dec 15, 2018. It is now read-only.
Enable VM Test and Use Latest Deb URL flag #443
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/assign @sebastienvas @rkpagadala @hklai |
rkpagadala
reviewed
Mar 6, 2018
prow/e2e-suite.sh
Outdated
| @@ -66,6 +66,7 @@ trap cleanup EXIT | |||
| # use uploaded yaml artifacts rather than the ones generated locally | |||
| DAILY_BUILD=istio-$(echo ${ISTIOCTL_URL} | cut -d '/' -f 6) | |||
| LINUX_DIST_URL=${ISTIOCTL_URL/istioctl/${DAILY_BUILD}-linux.tar.gz} | |||
| DEB_URL=${ISTIOCTL_URL/istioctl/deb} | |||
There was a problem hiding this comment.
please add comment about this weird substitution thing.
There was a problem hiding this comment.
I rebased from your change so we no longer have to do substitution
|
The flag |
|
@chxchx: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please do retest and only merge after istio/istio#3993
also fixes istio/istio#3995