-
Notifications
You must be signed in to change notification settings - Fork 315
markdown: move BlackFriday to goldmark #2168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Looking into this change more I think we need to change the rendering option removing xhtml and breaks and add unsafe. Testing with that now. |
Above from looking at the istio.io config.tml |
Not necessarily sure why, but making the changes above did not reflect differently in the generated Figured out the issue. The tools |
Creating a simple program and running it:
seems to show a better output:
With the current code:
which shows the two differences. |
I will take a look |
fix: istio/istio#41377
running
make containers-test
, got imagegcr.io/istio-testing/build-tools:master-latest-amd64
then running
istio/api
with this image, everything looks good.