Add istio/istio e2e-suite #362
Conversation
|
/lgtm /approve no-issue |
|
if this goes in before #365 I will put 0.2.0 also for post submit after rebase looks like the bot doesn't auto merge this repo? |
|
@ldemailly auto merge has been disabled for this PR because of the do-not-merge label -- not sure why the label was put there but otherwise it would be merged by the submit queue. |
|
looks like my pr went it before this (thanks!) so can you put 0.2.0 for all istio/istio images/config |
There was a problem hiding this comment.
as I recall it, you wanted to run these two jobs in parallel right?
This is expressing that you first run the non rbac and then after succes the rbac. So if no rbac takes 30 mins and rbac takes 30 mins it takes an hour to see two successes...whereas both in parallel could take more like ~30 mins.
Of course the tradeoff is it uses more resources.
Thoughts?
|
also as Laurent mentioned, we should make these be the prowbazel 0.2 image |
|
btw the image I made is still not enough so I'm looking at building another one and pulling my hair... |
|
make that 0.2.1 (#366) - thanks ! |
|
/lgtm cancel //PR changed after LGTM, removing LGTM. @sebastienvas @yutongz |
|
/approve no-issue |
|
/lgtm |
|
@rshriram mentioned that Envoy doesn't work/crashes on the latest Docker CE so we might need to keep 0.1.7 for proxy build (or try locally/confirm and/or change it but be ready to put back 0.1.7 if something goes wrong) - it's unclear also if it's a build or run time issue (as istio/istio build works fine with 0.2.1) |
|
proxy is currently build on Jenkins so your change is already active for Proxy. |
|
jenkins is using the prow image 0.2.1 ? |
|
Jenkins build its own image as a post submit.
On Aug 9, 2017 4:07 PM, "Laurent Demailly" <notifications@github.com> wrote:
jenkins is using the prow image 0.2.1 ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#362 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AQ80Z_-7upCbkgFzodzcTiEg0Jhi5pmUks5sWjusgaJpZM4OtI67>
.
|
|
/lgtm cancel //PR changed after LGTM, removing LGTM. @sebastienvas @yutongz |
|
/do-not-merge cancel |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
|
CLAs look good, thanks! |
|
@sebastienvas PTAL and which prowbazel we should use? I am lost in that part. |
|
Since you are running all combination as part of run after, does it mean that we can remove the e2e from the presubmit ? |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sebastienvas, yutongz The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
|
@yutongz: I updated Prow config for you!. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Yes, that's the plan. I will remove it until I am confident about the new tests. |
And post-submit job on istio/istio to run e2e-test suite with rbac and auth.
Will add kube-config of e2e-testing-rbac(cluster with rbac) as a secret to prow cluster after Seb re-create all clusters.
Add do-not-merge label to block merge until everything is in.
Release note: