rewrite package codecov check, upload report #235
Conversation
|
This is a test. |
|
Jenkins job test-infra/presubmit passed |
toolbox/pkg_check/main.go
Outdated
|
|
||
| var ( | ||
| reportFile = flag.String("report_file", "codecov.report", "Package code coverage report.") | ||
| requirementFile = flag.String("requirement_file", "codecov.requirement", "Package code coverage requuirement.") |
|
PTAL |
|
This is a test. |
|
Jenkins job test-infra/presubmit passed |
toolbox/pkg_check/main.go
Outdated
| } | ||
| }() | ||
|
|
||
| scanner := bufio.NewScanner(f) |
There was a problem hiding this comment.
Could you please give the format of the text you are trying to parse. It would help the reviewer understand what you are doing.
toolbox/pkg_check/main.go
Outdated
| return scanner.Err() | ||
| } | ||
|
|
||
| func (c *codecovChecker) checkRequirement() error { |
There was a problem hiding this comment.
Same comment here. Please provide a sample requirement file.
toolbox/pkg_check/main.go
Outdated
| scanner := bufio.NewScanner(f) | ||
| for scanner.Scan() { | ||
| parts := strings.Split(scanner.Text(), "\t") | ||
| if len(parts) == 2 { |
There was a problem hiding this comment.
should you log a warning in the other case ?
|
This is a test. |
1 similar comment
|
This is a test. |
|
Jenkins job test-infra/presubmit passed |
|
PTAL |
toolbox/pkg_check/main.go
Outdated
| //Report example: "ok istio.io/mixer/adapter/denyChecker 0.023s coverage: 100.0% of statements" | ||
| //Report example: "? istio.io/mixer/adapter/denyChecker/config [no test files]" | ||
| //expected output: c.codeCoverage["istio.io/mixer/adapter/denyChecker"] = 100 | ||
| for scanner.Scan() { |
There was a problem hiding this comment.
This seems very flaky. You should probably use a regular expression to extract the information.
|
This is a test. |
|
Jenkins job test-infra/presubmit passed |
|
PTAL |
|
This is a test. |
|
Jenkins job test-infra/presubmit passed |
No description provided.