-
Notifications
You must be signed in to change notification settings - Fork 181
Install fpm in prowbazel and istio-builder images #684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/assign @sebastienvas @mattdelco @hklai |
/lgtm |
The change appears to be adequate to get fpm added, but it's probably also appropriate to add: https://github.com/istio/test-infra/blob/master/docker/istio_builders/Makefile and maybe this one (but perhaps it's basically unused now and if anything should be deleted): https://github.com/istio/test-infra/blob/master/docker/prowbazel/Makefile I'm not entirely clear if anyone still uses these Makefiles anymore to generate the images or if instead people basically just run "docker build" and push it manually. |
/test all [submit-queue is verifying that this PR is safe to merge] |
/hold |
@mattdelco @rkpagadala |
/hold cancel |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rkpagadala The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. |
Trying to fix istio/istio#3279 which eventually will fix istio/istio#2444