Skip to content

Conversation

chxchx
Copy link
Contributor

@chxchx chxchx commented Feb 8, 2018

Trying to fix istio/istio#3279 which eventually will fix istio/istio#2444

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Feb 8, 2018
@chxchx
Copy link
Contributor Author

chxchx commented Feb 8, 2018

/assign @sebastienvas @mattdelco @hklai

@rkpagadala
Copy link
Contributor

/lgtm

@mattdelco
Copy link

The change appears to be adequate to get fpm added, but it's probably also appropriate to add:

https://github.com/istio/test-infra/blob/master/docker/istio_builders/Makefile

and maybe this one (but perhaps it's basically unused now and if anything should be deleted):

https://github.com/istio/test-infra/blob/master/docker/prowbazel/Makefile

I'm not entirely clear if anyone still uses these Makefiles anymore to generate the images or if instead people basically just run "docker build" and push it manually.

@istio-merge-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@rkpagadala
Copy link
Contributor

rkpagadala commented Feb 8, 2018

/hold
matt / charles you can remove the hold once your concerns are addressed.
I did not want the bot to merge too fast.

@istio-testing istio-testing added the do-not-merge/hold Block automatic merging of a PR. label Feb 8, 2018
@chxchx
Copy link
Contributor Author

chxchx commented Feb 8, 2018

@mattdelco @rkpagadala
Those two make files are in use (manual invocation of make image; make push is needed to create new image with fpm) and in fact their docker files call the linux-install-software script to install the prereqs.
See https://github.com/istio/test-infra/blob/master/docker/istio_builders/istio_builder/Dockerfile#L17
and https://github.com/istio/test-infra/blob/master/docker/prowbazel/Dockerfile#L17
If no other concern, please comment hold cancel

@rkpagadala
Copy link
Contributor

/hold cancel
/lgtm

@istio-testing istio-testing removed the do-not-merge/hold Block automatic merging of a PR. label Feb 8, 2018
@istio-merge-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rkpagadala

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@istio-merge-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@istio-merge-robot
Copy link

Automatic merge from submit-queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants