Skip to content

Conversation

AndreaM12345
Copy link

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@AndreaM12345 AndreaM12345 added the release-notes-none Indicates a PR that does not require release notes. label Jan 19, 2023
@AndreaM12345 AndreaM12345 requested a review from a team January 19, 2023 14:36
@istio-testing istio-testing added needs-rebase Indicates a PR needs to be rebased before being merged size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 19, 2023
adjust envoy sha
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR needs to be rebased before being merged size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 19, 2023
@AndreaM12345 AndreaM12345 mentioned this pull request Jan 19, 2023
37 tasks
@AndreaM12345
Copy link
Author

/retest

@@ -91,7 +91,7 @@ mirror-licenses: mod-download-go
@license-lint --mirror

TMP := $(shell mktemp -d -u)
UPDATE_BRANCH ?= "master"
UPDATE_BRANCH ?= "release-1.17"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't need to be in this one, but it's OK.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this wasn't merged before Step 5 was done, I have the Step 5 stuff in the other PR to fix this up.

@ericvn
Copy link

ericvn commented Jan 19, 2023

I will merge this PR for the RM since it's to the 1.17 branch which is rightfully controlled by them and this is just setting up that permission.

@ericvn ericvn merged commit 229f279 into istio:release-1.17 Jan 19, 2023
@pmerrison pmerrison mentioned this pull request Mar 23, 2023
30 tasks
@ksubrmnn ksubrmnn mentioned this pull request Jun 14, 2023
30 tasks
@hanxiaop hanxiaop mentioned this pull request Sep 14, 2023
30 tasks
@aryan16 aryan16 mentioned this pull request Jan 8, 2024
8 tasks
@zirain zirain mentioned this pull request Apr 19, 2024
32 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants