Skip to content

Conversation

rlenglet
Copy link
Contributor

@rlenglet rlenglet commented Mar 30, 2018

Use a version of Envoy that implements transparent listen sockets (envoyproxy/envoy#2719).

Related: istio/istio#4651
Required by: istio/istio#4654

Signed-off-by: Romain Lenglet romain@covalent.io

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@istio-testing
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: lizan

Assign the PR to them by writing /assign @lizan in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Mar 30, 2018
@rlenglet
Copy link
Contributor Author

I signed it!

@rlenglet
Copy link
Contributor Author

Please note that this PR can't be merged yet. It is blocked on envoyproxy/envoy#2719 getting merged first. However, I'd like to get early feedback on this if possible.

@qiwzhang
Copy link
Contributor

/ok-to-test

Signed-off-by: Romain Lenglet <romain@covalent.io>
@rlenglet
Copy link
Contributor Author

envoyproxy/envoy#2719 was merged upstream into Envoy. Updated this PR to pick the upstream commit.

@lizan
Copy link
Contributor

lizan commented Mar 30, 2018

Please sign the CLA. LGTM otherwise.

@rlenglet
Copy link
Contributor Author

rlenglet commented Mar 30, 2018

@lizan I already signed the CLA. Thanks!

@qiwzhang qiwzhang merged commit cb605f2 into istio:master Mar 30, 2018
@rlenglet rlenglet deleted the update-envoy-transparent-listener branch March 30, 2018 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants