fix circuit breaking task, related to https://github.com/istio/istio/… #960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geeknoid
approved these changes
Feb 9, 2018
ayj
reviewed
Feb 9, 2018
| @@ -19,7 +19,7 @@ This task demonstrates the circuit-breaking capability for resilient application | |||
| which will be used as the backend service for our task | |||
|
|
|||
| ```bash | |||
| kubectl apply -f <(istioctl kube-inject -f samples/httpbin/httpbin.yaml) | |||
| kubectl apply -f <(istioctl kube-inject --debug -f samples/httpbin/httpbin.yaml) | |||
There was a problem hiding this comment.
What does this fix? Are debug images and/or additional logging required for this task?
|
Yes -- one of the last steps expects to be able to query the envoy admin
stats.
…On Fri, Feb 9, 2018 at 11:51 AM, Jason Young ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In _docs/tasks/traffic-management/circuit-breaking.md
<#960 (comment)>:
> @@ -19,7 +19,7 @@ This task demonstrates the circuit-breaking capability for resilient application
which will be used as the backend service for our task
```bash
- kubectl apply -f <(istioctl kube-inject -f samples/httpbin/httpbin.yaml)
+ kubectl apply -f <(istioctl kube-inject --debug -f samples/httpbin/httpbin.yaml)
What does this fix? Are debug images and/or additional logging required
for this task?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#960 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AADP0a4iJmBahk77LBepkMWhXGwF5_Lnks5tTJObgaJpZM4R_9O->
.
--
*Christian Posta*
twitter: @christianposta
http://blog.christianposta.com <http://www.christianposta.com/blog>
|
ayj
approved these changes
Feb 9, 2018
|
could be useful to explain that on the page |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…pull/3351