Skip to content

Fix misuses of "rollback" and "rollout" as verbs. #9377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2021
Merged

Fix misuses of "rollback" and "rollout" as verbs. #9377

merged 1 commit into from
Mar 24, 2021

Conversation

dsbos
Copy link
Contributor

@dsbos dsbos commented Mar 23, 2021 •
edited
Loading

[ ] Configuration Infrastructure
[x] Docs
[ ] Installation
[ ] Networking
[ ] Performance and Scalability
[ ] Policies and Telemetry
[ ] Security
[ ] Test and Release
[ ] User Experience
[ ] Developer Infrastructure

@dsbos dsbos requested a review from a team as a code owner March 23, 2021 19:32
@google-cla google-cla bot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Mar 23, 2021
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 23, 2021
@istio-testing
Copy link
Contributor

Hi @dsbos. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ericvn
Copy link
Contributor

ericvn commented Mar 23, 2021

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Mar 23, 2021
@ericvn ericvn added the cherrypick/master Set this label on a PR to auto-merge from a release branch to master label Mar 24, 2021
frankbu
frankbu approved these changes Mar 24, 2021
View reviewed changes
Copy link
Collaborator

@frankbu frankbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the corrections!

@istio-testing istio-testing merged commit b015936 into istio:release-1.9 Mar 24, 2021
@ericvn
Copy link
Contributor

ericvn commented Mar 25, 2021

/cherry-pick master

@istio-testing
Copy link
Contributor

@ericvn: new pull request created: #9395

In response to this:

/cherry-pick master

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@istio-testing istio-testing mentioned this pull request Mar 25, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankbu frankbu frankbu approved these changes

Assignees
No one assigned
Labels
cherrypick/master Set this label on a PR to auto-merge from a release branch to master cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dsbos @istio-testing @ericvn @frankbu