Skip to content

Conversation

istio-testing
Copy link
Contributor

This is an automated cherry-pick of #9288

@istio-testing istio-testing requested a review from a team as a code owner March 17, 2021 22:48
@istio-testing istio-testing added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Mar 17, 2021
@istio-testing istio-testing added the release-notes-none Indicates a PR that does not require release notes. label Mar 17, 2021
@google-cla
Copy link

google-cla bot commented Mar 17, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. labels Mar 17, 2021
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 17, 2021
@davidhauck
Copy link
Member

@googlebot I consent.

@google-cla google-cla bot added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Mar 17, 2021
@ericvn
Copy link
Contributor

ericvn commented Mar 18, 2021

/retest

@ericvn
Copy link
Contributor

ericvn commented Mar 18, 2021

More investigation on why the tests are failing. Looking at the first one, the last thing I see in the output is:

unable to recognize "STDIN": no matches for kind "EnvoyFilter" in version "networking.istio.io/v1alpha3"
unable to recognize "STDIN": no matches for kind "EnvoyFilter" in version "networking.istio.io/v1alpha3"
unable to recognize "STDIN": no matches for kind "EnvoyFilter" in version "networking.istio.io/v1alpha3"
unable to recognize "STDIN": no matches for kind "EnvoyFilter" in version "networking.istio.io/v1alpha3"
unable to recognize "STDIN": no matches for kind "EnvoyFilter" in version "networking.istio.io/v1alpha3"
unable to recognize "STDIN": no matches for kind "EnvoyFilter" in version "networking.istio.io/v1alpha3"
unable to recognize "STDIN": no matches for kind "EnvoyFilter" in version "networking.istio.io/v1alpha3"
unable to recognize "STDIN": no matches for kind "EnvoyFilter" in version "networking.istio.io/v1alpha3"

I looked back and don't see the issue in the last passing test.

It seems that a lot of people might be simply approving Doc changes and something has broken things.

@ericvn
Copy link
Contributor

ericvn commented Mar 18, 2021

/retest

@ericvn
Copy link
Contributor

ericvn commented Mar 18, 2021

I did run the default profile tests locally (on current branch without this change) and I'm seeing the same two tests fail.

@ericvn
Copy link
Contributor

ericvn commented Mar 18, 2021

/retest

@ericvn
Copy link
Contributor

ericvn commented Mar 18, 2021

I cherrypicked a number of PRs related to a kubectl update. Was done on master a while ago, but was hidden in a change on release-1.9 (an older tools change was never pulled into common-files when it was merged and ending up getting pulled in with a later change).

@istio-testing istio-testing merged commit 101d179 into istio:release-1.9 Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. release-notes-none Indicates a PR that does not require release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants