Skip to content

Conversation

geeknoid
Copy link
Contributor

@geeknoid geeknoid commented Nov 3, 2017

No description provided.

@geeknoid geeknoid requested a review from douglas-reid November 3, 2017 13:20
@istio-testing
Copy link
Contributor

Jenkins job istio.github.io/presubmit passed

1 similar comment
@istio-testing
Copy link
Contributor

Jenkins job istio.github.io/presubmit passed


In addition to insulating application-level code from the details of infrastructure backends, Mixer provides an intermediation model that allows operators to inject and control policies between application code and backends. Operators can control which data is reported to which backend, which backend to consult for authorization, and much more.

Given that individual infrastructure backends each have different interfaces and operational models, Mixer needs custom code to deal with each and we call these custom bundles of code *[adapter*s](https://github.com/istio/istio/blob/master/mixer/doc/dev/adapters.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like the '*'s surrounding adapter aren't doing what is intended. Here and elsewhere (templates, instances, rules), should this be: [*adapter*s] (instead of *[adapter*s]) ?

@geeknoid
Copy link
Contributor Author

geeknoid commented Nov 3, 2017

Ugh, those are markdown conversion errors. They're fixed now.

Good catch.

PTAL.

Copy link
Contributor

@douglas-reid douglas-reid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small markdown issue (at least in github's view mode).

## Instances: Attribute Mapping

You control which data is delivered to individual adapters by creating [*instances*](https://istio.io/docs/concepts/policy-and-control/mixer-config
.html#instances). Instances control how Mixer uses the [attributes](https://istio.io/docs/concepts/policy-and-control/attributes.html) delivered by the proxy into individual bundles of data that can be routed to different adapters.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the line break here (between mixer-config and .html) screws up the markdown for the link.

@geeknoid
Copy link
Contributor Author

geeknoid commented Nov 3, 2017 via email

@istio-testing
Copy link
Contributor

Jenkins job istio.github.io/presubmit passed

@geeknoid geeknoid merged commit c58e017 into istio:master Nov 3, 2017
@geeknoid geeknoid deleted the blog branch November 25, 2017 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants