Skip to content

Conversation

gyliu513
Copy link
Member

All of the 1.7 kubernetes can works well with istio CRD resources,
we should update it to avoid confuse.

/cc @linsun

@istio-testing
Copy link
Contributor

Jenkins job istio.github.io/presubmit passed

Copy link
Member

@ldemailly ldemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it doesn’t work with 1.7.2 which is why it says 1.7.4 or newer

@gyliu513
Copy link
Member Author

gyliu513 commented Nov 1, 2017

@ldemailly what is the reason of 1.7.2 does not work, at least it works for 1.7.3 in my env.

@ldemailly
Copy link
Member

I forget but there was an issue - going to close this for now

@ldemailly ldemailly closed this Nov 1, 2017
@gyliu513
Copy link
Member Author

gyliu513 commented Nov 3, 2017

@ldemailly I think that we need to update kubectl version to 1.7.3 as 1.7.3 also works, I got some question from customers about the version who is using 1.7.3, so better update to 1.7.3

@gyliu513 gyliu513 reopened this Nov 3, 2017
All of the 1.7 kubernetes can works well with istio CRD resources,
we should update it to avoid confuse.
@istio-testing
Copy link
Contributor

Jenkins job istio.github.io/presubmit passed

2 similar comments
@istio-testing
Copy link
Contributor

Jenkins job istio.github.io/presubmit passed

@istio-testing
Copy link
Contributor

Jenkins job istio.github.io/presubmit passed

@linsun linsun self-requested a review November 3, 2017 14:45
@linsun
Copy link
Member

linsun commented Nov 3, 2017

Updating to 1.7.3 is fine with me given Guang has tested it and we didn't recall any issue but we picked 1.7.4 given it was the latest.

@linsun linsun removed their request for review November 3, 2017 14:48
@ldemailly ldemailly requested a review from andraxylia November 3, 2017 14:59
@ldemailly
Copy link
Member

I am pretty sure there is a bug with older than 1.7.4 but maybe it was only initializer related ? or was it about validation hooks ? @andraxylia do you remember?

@gyliu513
Copy link
Member Author

gyliu513 commented Nov 3, 2017

@ldemailly We have a wechat group for istio in China and I got some questions for the kubernetes version for istio, and some people are using 1.7.3 and they also did some test and found istio works well. I think that we should update the document so as not bring confuse, comments?

@ldemailly
Copy link
Member

sorry to keep repeating the same thing but I'm sure there was a reason (it's not that we picked the latest at the time) - maybe if you go over the release notes it may show up but I hope @andraxylia or @ayj or someone remembers

@ayj
Copy link
Contributor

ayj commented Nov 3, 2017

I don't recall the reason. Maybe a GKE specific requirement since they bump up the latest minor version frequently and make previous minor versions unavailable for new clusters?

@ldemailly
Copy link
Member

I searched a bit and didn't find except that we put 1.7.4 for the first time in 0.2.2
https://github.com/istio/istio/wiki/v0.2.2
I guess go ahead and merge and we'll see if we get reports/errors

@istio-testing
Copy link
Contributor

Jenkins job istio.github.io/presubmit passed

@linsun
Copy link
Member

linsun commented Nov 4, 2017

Thanks for digging around, I'll merge it.

@linsun linsun merged commit 47a226c into istio:master Nov 4, 2017
@gyliu513 gyliu513 deleted the k8s-version branch November 4, 2017 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants