Skip to content

[release-1.4] Release 1.4.6 #6709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 3, 2020
Merged

[release-1.4] Release 1.4.6 #6709

merged 3 commits into from
Mar 3, 2020

Conversation

istio-testing
Copy link
Contributor

This is an automated cherry-pick of #6708

Eric Van Norman added 2 commits March 3, 2020 18:22
@istio-testing
ISTIO 2020-003 (istio#3)
106c7d7 
* ISTIO 2020-003

* Code review comments

* Update vectors
@istio-testing
Update text box syntax
e50bae0
@istio-testing istio-testing requested a review from a team as a code owner March 3, 2020 18:22
@istio-testing istio-testing mentioned this pull request Mar 3, 2020
Merged
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Mar 3, 2020
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 3, 2020
@duderino duderino added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Mar 3, 2020
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@howardjohn howardjohn requested a review from a team as a code owner March 3, 2020 18:24
@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. and removed cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. labels Mar 3, 2020
@duderino duderino added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Mar 3, 2020
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@fpesce fpesce merged commit 3d0fdc0 into istio:release-1.4 Mar 3, 2020
@istio-testing
Copy link
Contributor Author

@istio-testing: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
lint_istio.io_release-1.4 8e6350a link /test lint_istio.io_release-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

so-jelly pushed a commit to so-jelly/istio.io that referenced this pull request Mar 14, 2020
@istio-testing @howardjohn
[release-1.4] Release 1.4.6 (istio#6709)
83d7984 
* ISTIO 2020-003 (istio#3)

* ISTIO 2020-003

* Code review comments

* Update vectors

* Update text box syntax

* Fix args

Co-authored-by: Eric Van Norman <ericvn@us.ibm.com>
Co-authored-by: John Howard <howardjohn@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@howardjohn howardjohn howardjohn approved these changes

Assignees

@ericvn ericvn

Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@istio-testing @googlebot @howardjohn @duderino @fpesce @ericvn