Skip to content

Release 1.4.6 #6708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 3, 2020
Merged

Release 1.4.6 #6708

merged 2 commits into from
Mar 3, 2020

Conversation

ericvn
Copy link
Contributor

@ericvn ericvn commented Mar 3, 2020 •
edited by istio-policy-bot
Loading

No description provided.

Eric Van Norman added 2 commits March 3, 2020 10:30
ISTIO 2020-003 (istio#3)
4df40c7 
* ISTIO 2020-003

* Code review comments

* Update vectors
Update text box syntax
23f1eb6
@ericvn ericvn requested a review from a team as a code owner March 3, 2020 18:00
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Mar 3, 2020
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Mar 3, 2020
adammil2000
adammil2000 approved these changes Mar 3, 2020
View reviewed changes
Copy link
Contributor

@adammil2000 adammil2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@istio-testing
Copy link
Contributor

@ericvn: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
lint_istio.io 23f1eb6 link /test lint_istio.io

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@fpesce fpesce merged commit 806b1ab into istio:master Mar 3, 2020
@istio-testing istio-testing mentioned this pull request Mar 3, 2020
Merged
@istio-testing
Copy link
Contributor

In response to a cherrypick label: new pull request created: #6709

@ericvn ericvn deleted the cve branch March 3, 2020 18:33
lei-tang pushed a commit to lei-tang/istio.github.io that referenced this pull request Mar 5, 2020
@lei-tang
Release 1.4.6 (istio#6708)
bdbf45e 
* ISTIO 2020-003 (istio#3)

* ISTIO 2020-003

* Code review comments

* Update vectors

* Update text box syntax
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@adammil2000 adammil2000 adammil2000 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ericvn @istio-testing @adammil2000 @fpesce @googlebot