Integrate VM's guide: add specific commands for Mysql VM #659

saumoh · 2017-10-12T19:04:23Z

Add specific commands to support a vm running mysql db that has been setup with the ratings db.

istio-testing · 2017-10-12T19:07:34Z

Jenkins job istio.github.io/presubmit passed

ldemailly · 2017-10-12T19:57:01Z

See also #657
and istio/istio#1114

Rachael-Graham

tech writer review

Rachael-Graham · 2017-10-12T22:56:38Z

_docs/guides/integrating-vms.md

-### Machine admin
-First step is to configure the VM sidecar, by adding the service port and restarting the sidecar.
+```
+On the VM add ratings database to mysql. To make it easy to visually inspect the difference in the output of the bookinfo application you can change the ratings that are generated by ratings service.


add comma after application

Rachael-Graham · 2017-10-12T22:57:17Z

_docs/guides/integrating-vms.md

-  # add mysql port to the "ISTIO_INBOUND_PORTS" config
-  ```
+## Registering the mysql service with the mesh
+On a host with access to istioctl commands register the VM and mysql db service


On a host with access to istioctl commands, register the VM .."

Rachael-Graham · 2017-10-12T22:57:54Z

_docs/guides/integrating-vms.md

-  ```
-
-  Note that the 'db' machine does not need and should not have special kubernetes priviledges.
+  Note that the 'mysqldb' virtual machine does not need and should not have special kubernetes priviledges.


special Kubernetes privileges.

Rachael-Graham · 2017-10-12T22:58:54Z

_docs/guides/integrating-vms.md


 ## Using the mysql service

-The ratings service in bookinfo will use the DB on the machine. To verify it works, you can
-modify the ratings value on the database.
+The ratings service in bookinfo will use the DB on the machine. To verify it works, create versio 2 of the ratings service that uses the mysql db on the VM. Then specify route rules that force review service to use the ratings version 2.


To verify that it works, create version 2

that force the review service

ldemailly · 2017-10-13T00:51:22Z

that's awesome, thanks, can you make the changes Rachael kindly suggested

istio-testing · 2017-10-13T06:19:21Z

Jenkins job istio.github.io/presubmit passed

ldemailly · 2017-10-13T16:44:00Z

_docs/guides/integrating-vms.md

@@ -31,34 +31,41 @@ this infrastructure as a single mesh.
  [Installation guide]({{home}}/docs/setup/kubernetes/quick-start.html).

 * Deploy the [BookInfo]({{home}}/docs/guides/bookinfo.html) sample application.
-
-* Create a VM named 'db' in the same project as Istio cluster, and [Join the Mesh]({{home}}/docs/setup/kubernetes/mesh-expansion.html).
+* Create a VM named 'mysqldb' in the same project as Istio cluster, and [Join the Mesh]({{home}}/docs/setup/kubernetes/mesh-expansion.html).


in the same project as your Istio cluster
(or the Istio cluster) ?

also the name of the VM doesn't (should not) matter; maybe "vm-1" is better to not imply otherwise ?

ldemailly · 2017-10-13T16:45:52Z

_docs/guides/integrating-vms.md

+  sudo apt-get update && sudo apt-get install -y mariadb-server
+  sudo mysql
+  # Grant remote access by root to db server
+  GRANT ALL PRIVILEGES ON *.* TO 'root'@'%' IDENTIFIED BY 'password' WITH GRANT OPTION;


with the sidecar this shouldn't be necessary ? (all connections appear to come from localhost) no ?

good point. Just root@localhost should do it.

ldemailly · 2017-10-13T16:46:31Z

_docs/guides/integrating-vms.md

+On the VM add ratings database to mysql. To make it easy to visually inspect the difference in the output of the bookinfo application, you can change the ratings that are generated by ratings service.
+```bash
+  # Add ratings db to the mysql db
+  curl -q https://raw.githubusercontent.com/istio/istio/master/samples/bookinfo/src/mysql/mysqldb-init.sql | sed -e 's/VALUES (\(.*\),.*/VALUES (\1, 1);/g' | sudo mysql


what's the sed doing ? we can fix the script if there is an issue with it (which issue?)

here i am changing the out put so that there is 1 star rating by each reviewer. Without this change it's really hard to know -visually-is the ratings db is generating the output or not.
There is nothing wrong with the data in the db it's just hard to differentiate the outputs compared to the output of non-mysql ratings service.

I prefer to do that with an update (that can be repeated)

ldemailly · 2017-10-13T16:47:45Z

_docs/guides/integrating-vms.md

+kubectl create -f samples/bookinfo/kube/bookinfo-mysql.yaml
+
+# Create route rules that will force bookinfo to use the ratings back end
+istioctl create -f samples/bookinfo/kube/route-rule-ratings-db.yaml


I think you want the -mysql versions here

bookinfo-mysql.yaml will create a version of the ratings service that is backed my mysql-db.
the route rule 'route-rule-ratings-db.yaml' will send all ratings svc traffic to that version of ratings service.
The 'route-rule-ratings-db' is common to both mongodb and mysqldb.

istio-testing · 2017-10-13T19:17:20Z

Jenkins job istio.github.io/presubmit passed

istio-testing · 2017-10-14T21:42:31Z

Jenkins job istio.github.io/presubmit passed

ldemailly · 2017-10-15T05:41:02Z

_docs/guides/integrating-vms.md

@@ -31,34 +31,41 @@ this infrastructure as a single mesh.
  [Installation guide]({{home}}/docs/setup/kubernetes/quick-start.html).

 * Deploy the [BookInfo]({{home}}/docs/guides/bookinfo.html) sample application.
-
-* Create a VM named 'db' in the same project as Istio cluster, and [Join the Mesh]({{home}}/docs/setup/kubernetes/mesh-expansion.html).
+* Create a VM named 'mysqldb' in the same project as Istio cluster, and [Join the Mesh]({{home}}/docs/setup/kubernetes/mesh-expansion.html).


also the name of the VM doesn't (should not) matter; maybe "vm-1" is better to not imply otherwise ?

ldemailly · 2017-10-15T05:43:20Z

_docs/guides/integrating-vms.md

+  # Grant access to root
+  GRANT ALL PRIVILEGES ON *.* TO 'root'@'localhost' IDENTIFIED BY 'password' WITH GRANT OPTION;
+  quit;
+  # Allow remote access to mysql


also remove, not needed

ldemailly · 2017-10-15T05:45:07Z

_docs/guides/integrating-vms.md

+On the VM add ratings database to mysql. To make it easy to visually inspect the difference in the output of the bookinfo application, you can change the ratings that are generated by ratings service.
+```bash
+  # Add ratings db to the mysql db
+  curl -q https://raw.githubusercontent.com/istio/istio/master/samples/bookinfo/src/mysql/mysqldb-init.sql | sed -e 's/VALUES (\(.*\),.*/VALUES (\1, 1);/g' | sudo mysql


I prefer to do that with an update (that can be repeated)

ldemailly · 2017-10-15T05:48:41Z

_docs/guides/integrating-vms.md

+On the VM add ratings database to mysql. To make it easy to visually inspect the difference in the output of the bookinfo application, you can change the ratings that are generated by ratings service.
+```bash
+  # Add ratings db to the mysql db
+  curl -q https://raw.githubusercontent.com/istio/istio/master/samples/bookinfo/src/mysql/mysqldb-init.sql | sed -e 's/VALUES (\(.*\),.*/VALUES (\1, 1);/g' | sudo mysql


after the grant you need --password=password (and don't need sudo); lets use

curl https://raw.githubusercontent.com/istio/istio/master/samples/bookinfo/src/mysql/mysqldb-init.sql | mysql -u root --password=password

and add examples

$ mysql -u root --password=password test -e "select * from ratings;" +----------+--------+ | ReviewID | Rating | +----------+--------+ | 1 | 5 | | 2 | 4 | +----------+--------+

and

$ mysql -u root --password=password test -e "update ratings set rating=1 where reviewid=1;select * from ratings" +----------+--------+ | ReviewID | Rating | +----------+--------+ | 1 | 1 | | 2 | 4 | +----------+--------+

ldemailly · 2017-10-15T05:49:44Z

_docs/guides/integrating-vms.md

+## Registering the mysql service with the mesh
+On a host with access to `istioctl` commands, register the VM and mysql db service
+```bash
+   istioctl -n default register mysqldb <ip-address-of-vm> 3306


-n default seems off

let's show the output too

$ istioctl register mysqldb 10.150.0.5 3306 http:8080 I1014 22:54:12.176972 18162 register.go:44] Registering for service 'mysqldb' ip '10.150.0.5', ports list [{3306 mysql} {8080 http}] I1014 22:54:12.177248 18162 register.go:49] 0 labels ([]) and 1 annotations ([alpha.istio.io/kubernetes-serviceaccounts=default]) W1014 22:54:13.194812 18162 register.go:123] Got 'services "mysqldb" not found' looking up svc 'mysqldb' in namespace 'default', attempting to create it W1014 22:54:13.679181 18162 register.go:139] Got 'endpoints "mysqldb" not found' looking up endpoints for 'mysqldb' in namespace 'default', attempting to create them I1014 22:54:13.954414 18162 register.go:180] No pre existing exact matching ports list found, created new subset {[{10.150.0.5 <nil> nil}] [] [{mysql 3306 } {http 8080 }]} I1014 22:54:14.243637 18162 register.go:191] Successfully updated mysqldb, now with 2 endpoints

…f vm.

…b.io into integvms

istio-testing · 2017-10-16T05:35:54Z

Jenkins job istio.github.io/presubmit passed

istio-testing · 2017-11-01T00:40:41Z

Jenkins job istio.github.io/presubmit passed

istio-testing · 2017-11-01T00:41:50Z

Jenkins job istio.github.io/presubmit passed

ldemailly · 2017-11-01T00:43:10Z

merging this as it's much better than previous content, we can refine later
(I just got the full demo working with auth and documented each step in a deck - will publish soon - also have one last patch/cherry pick in release-0.2 to add the files mentioned in this updated doc)

saumohos added 2 commits October 10, 2017 22:43

Initial changes for mysql support on vms

c0b13fa

Fix typos in mysql commands.

1ae9f2c

ldemailly requested review from ldemailly and costinm October 12, 2017 19:55

Rachael-Graham reviewed Oct 12, 2017

View reviewed changes

Incorporate edits from tech writers review.

1f55825

ldemailly reviewed Oct 13, 2017

View reviewed changes

Change grant to be at localhost.

3990ad7

Merge branch 'master' into integvms

1cdb553

ldemailly reviewed Oct 15, 2017

View reviewed changes

saumohos added 2 commits October 15, 2017 22:31

Add mysql commands to change ratings and show output of registering o…

4bd2988

…f vm.

Merge branch 'integvms' of https://github.com/colabsaumoh/istio.githu…

0ac219a

…b.io into integvms

ldemailly added 3 commits November 1, 2017 00:31

Merge branch 'master' into integvms

7b96371

fixing for missing kube-inject and correct yamls for .vm. namespace

6256a9e

minor update

c06ffb8

ldemailly approved these changes Nov 1, 2017

View reviewed changes

ldemailly merged commit 4cbbd44 into istio:master Nov 1, 2017

Integrate VM's guide: add specific commands for Mysql VM #659

Integrate VM's guide: add specific commands for Mysql VM #659

Uh oh!

Conversation

saumoh commented Oct 12, 2017

Uh oh!

istio-testing commented Oct 12, 2017

Uh oh!

ldemailly commented Oct 12, 2017

Uh oh!

Rachael-Graham left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ldemailly commented Oct 13, 2017

Uh oh!

istio-testing commented Oct 13, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

saumoh Oct 13, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

istio-testing commented Oct 13, 2017

Uh oh!

istio-testing commented Oct 14, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ldemailly Oct 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ldemailly Oct 15, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

istio-testing commented Oct 16, 2017

Uh oh!

istio-testing commented Nov 1, 2017

Uh oh!

istio-testing commented Nov 1, 2017

Uh oh!

ldemailly commented Nov 1, 2017

Uh oh!

Uh oh!

saumoh Oct 13, 2017 •

edited

Loading

ldemailly Oct 15, 2017 •

edited

Loading

ldemailly Oct 15, 2017 •

edited

Loading