Update the egrep and service accounts. #5523
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is after I tried to install with latest 1.4 daily build and istioctl manifest installation. Seems like the grep regex format needs to be updated and the service account we use for the sleep changed as well. |
diemtvu
reviewed
Nov 8, 2019
diemtvu
approved these changes
Nov 8, 2019
geeknoid
approved these changes
Nov 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the service account output and the egrep format (not sure why the old one does not work)
Test against latest build of 1.4 release,
istio-1.4-alpha.5385e895f4e045981a4369826389ea0fdbb2b9e6.