Skip to content

Fix bug istioctl manifest command does not read from standard input #5521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2019
Merged

Fix bug istioctl manifest command does not read from standard input #5521

merged 1 commit into from
Nov 8, 2019
+4 −2

Conversation

lei-tang
Copy link
Contributor

@lei-tang lei-tang commented Nov 8, 2019 •
edited by istio-policy-bot
Loading

Please provide a description for what this PR is for: Fix bug istioctl manifest command does not read from standard input

@lei-tang lei-tang requested a review from a team as a code owner November 8, 2019 18:23
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 8, 2019
@istio-testing istio-testing added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 8, 2019
@lei-tang lei-tang requested a review from frankbu November 8, 2019 18:24
@lei-tang lei-tang added this to the 1.4 milestone Nov 8, 2019
frankbu
frankbu approved these changes Nov 8, 2019
View reviewed changes
Copy link
Collaborator

@frankbu frankbu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should really open an issue for istioctl manifest apply to support read from stdin.

@istio-testing istio-testing merged commit 1d2c74a into istio:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankbu frankbu frankbu approved these changes

Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. kind/docs size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.
5 participants
@lei-tang @frankbu @googlebot @istio-testing @istio-policy-bot