Skip to content

Conversation

zyt312074545
Copy link
Contributor

@zyt312074545 zyt312074545 commented Nov 8, 2019

@zyt312074545 zyt312074545 requested a review from a team as a code owner November 8, 2019 06:29
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 8, 2019
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test labels Nov 8, 2019
@istio-testing
Copy link
Contributor

Hi @zyt312074545. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@zyt312074545
Copy link
Contributor Author

PR 对应的 issus 已关闭,本次 PR 补充之前文章中未添加的锚点

@geeknoid geeknoid added the translation/chinese Translation item label Nov 8, 2019
Copy link
Member

@rootsongjc rootsongjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@rootsongjc rootsongjc self-assigned this Nov 9, 2019
@rootsongjc
Copy link
Member

/ok-to-test

@istio-testing istio-testing added the ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. label Nov 9, 2019
@istio-testing istio-testing merged commit fe1acd4 into istio:master Nov 9, 2019
@zyt312074545 zyt312074545 deleted the zh-trans-1102 branch November 9, 2019 09:14
charili pushed a commit to charili/istio.io that referenced this pull request Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/chinese Translation item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants