Skip to content

Split up install to separate CRs #5436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 7, 2019
Merged

Split up install to separate CRs #5436

merged 2 commits into from
Nov 7, 2019

Conversation

ostromart
Copy link
Contributor

Existing install manifest can race leading to install errors.

@ostromart ostromart requested a review from geeknoid as a code owner November 6, 2019 23:50
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 6, 2019
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 6, 2019
@ostromart ostromart requested review from sdake and frankbu November 6, 2019 23:51
@ostromart ostromart mentioned this pull request Nov 7, 2019
Merged
@istio-testing istio-testing merged commit 81da298 into istio:master Nov 7, 2019
sdake pushed a commit to sdake/istio.github.io that referenced this pull request Nov 7, 2019
Revert "Split up install to separate CRs (istio#5436)"
60f445e 
Please see the script in script/grab_operator_yamls.sh.

This reverts commit 81da298.
istio-testing pushed a commit that referenced this pull request Nov 7, 2019
@istio-testing
Revert "Split up install to separate CRs (#5436)" (#5478)
1ad5326 
* Test of the docs checks

* Revert "Split up install to separate CRs (#5436)"

Please see the script in script/grab_operator_yamls.sh.

This reverts commit 81da298.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankbu frankbu frankbu approved these changes

@sdake sdake Awaiting requested review from sdake

+1 more reviewer

@geeknoid geeknoid geeknoid approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ostromart @frankbu @geeknoid @googlebot @istio-testing