Skip to content

zh-translation: /docs/setup/install/operator/index.md #5424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Nov 9, 2019
Merged

zh-translation: /docs/setup/install/operator/index.md #5424

merged 11 commits into from
Nov 9, 2019

Conversation

idefav
Copy link
Contributor

@idefav idefav commented Nov 6, 2019 •
edited by istio-policy-bot
Loading

@idefav idefav requested a review from a team as a code owner November 6, 2019 15:01
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 6, 2019
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test labels Nov 6, 2019
@istio-testing
Copy link
Contributor

Hi @idefav. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rootsongjc rootsongjc added the translation/chinese Translation item label Nov 7, 2019
rootsongjc
rootsongjc reviewed Nov 7, 2019
View reviewed changes
content/zh/docs/setup/install/operator/index.md Outdated

## Prerequisites
## 先决条件
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

所有的标题需要添加锚点

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经全部添加英文锚点

rootsongjc
rootsongjc reviewed Nov 7, 2019
View reviewed changes
content/zh/docs/setup/install/operator/index.md Outdated
[configuration profiles](/docs/setup/additional-setup/config-profiles/),
`istioctl manifest` provides a complete API for customizing the configuration.
除了安装 Istio 的任何内置组件 [配置文件](/zh/docs/setup/additional-setup/config-profiles/)，
`istioctl manifest` 提供了用于自定义配置的完整API。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

英文和中文间要加空格。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经修改

rootsongjc
rootsongjc reviewed Nov 7, 2019
View reviewed changes
content/zh/docs/setup/install/operator/index.md Outdated

To uninstall Istio, run the following command:
可以使用以下命令来卸载 Istio
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

漏了冒号

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经修改

rootsongjc
rootsongjc suggested changes Nov 7, 2019
View reviewed changes
Copy link
Member

@rootsongjc rootsongjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要修改。

@jakeslee
Copy link
Contributor

jakeslee commented Nov 7, 2019

@rootsongjc: The directory of file has been renamed from /content/en/docs/setup/install/operator to /content/en/docs/setup/install/istioctl. The content has been updated too. (ref: #5390)
These changes cause istio.io lint failed in PR #5385.
@idefav I think you can push a commit to fix this.

@rootsongjc
Copy link
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Nov 7, 2019
@rootsongjc rootsongjc self-assigned this Nov 8, 2019
rootsongjc
rootsongjc approved these changes Nov 8, 2019
View reviewed changes
Copy link
Member

@rootsongjc rootsongjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@idefav idefav requested a review from a team as a code owner November 8, 2019 13:26
rootsongjc
rootsongjc reviewed Nov 8, 2019
View reviewed changes
.spelling Outdated
@@ -70,6 +70,7 @@ analytics
ANDed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请不要修改该文件。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已经还原

@istio-testing istio-testing added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 9, 2019
@idefav
Copy link
Contributor Author

idefav commented Nov 9, 2019

@rootsongjc @jakeslee I have updated the opeator to istioctl directory and update the link from file helm/index.md

@istio-testing istio-testing merged commit ad5a46c into istio:master Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rootsongjc rootsongjc rootsongjc approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@rootsongjc rootsongjc

Labels
area/environments cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/chinese Translation item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@idefav @istio-testing @jakeslee @rootsongjc @googlebot @istio-policy-bot