Skip to content

Conversation

shicheng0829
Copy link
Contributor

@shicheng0829 shicheng0829 commented Nov 6, 2019

@shicheng0829 shicheng0829 requested a review from a team as a code owner November 6, 2019 12:30
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Nov 6, 2019
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 6, 2019
@istio-testing
Copy link
Contributor

Hi @shicheng0829. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shicheng0829
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Nov 6, 2019
@rootsongjc rootsongjc added the translation/chinese Translation item label Nov 6, 2019
@rootsongjc
Copy link
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Nov 6, 2019
@shicheng0829
Copy link
Contributor Author

/retest

@rootsongjc rootsongjc self-assigned this Nov 6, 2019
@@ -9,70 +9,69 @@ aliases:
keywords: [platform-setup,azure]
---

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

描述需要翻译,aliases 需要修改。

@shicheng0829
Copy link
Contributor Author

/retest

@@ -25,7 +25,7 @@ keywords: [platform-setup,azure]
$ az provider list --query "[?namespace=='Microsoft.ContainerService'].resourceTypes[] | [?resourceType=='managedClusters'].locations[]" -o tsv
{{< /text >}}

1. 证实对于期望的 region 有支持的 Kubernetes 版本
2. 证实对于期望的 region 有支持的 Kubernetes 版本
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请不要修改序号,所有的有序列表前全部使用 1,这不是错误。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我提交的最新的commit已修复这个问题

@shicheng0829
Copy link
Contributor Author

/retest

the value `myclustername`, a valid resource group with a unique cluster
ID is `mycluster-5adfba82`. The `aks-engine` generates your `kubeconfig`
file in the `_output` folder.
几分钟之后, 你能发现你的集群在你的Azure subscription上的
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

所有英文与中文间要有空格。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

所有英文与中文间要有空格。

已使用zhlint修改格式问题,感谢review :)

Copy link
Member

@rootsongjc rootsongjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@istio-testing istio-testing merged commit 1b98415 into istio:master Nov 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/chinese Translation item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants