Skip to content

Improve the root transition doc. #5499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Nov 9, 2019
Merged

Improve the root transition doc. #5499

merged 10 commits into from
Nov 9, 2019

Conversation

myidpt
Copy link

@myidpt myidpt commented Nov 8, 2019 •
edited by istio-policy-bot
Loading

No description provided.

@myidpt myidpt requested a review from a team as a code owner November 8, 2019 06:18
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 8, 2019
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 8, 2019
@myidpt myidpt requested a review from rcaballeromx November 8, 2019 20:16
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 8, 2019
@istio-testing istio-testing merged commit 7bd65f7 into istio:master Nov 9, 2019
@istio-testing
Copy link
Contributor

In response to a cherrypick label: #5499 failed to apply on top of branch "release-1.3":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	content/en/docs/ops/security/root-transition/index.md
Falling back to patching base and 3-way merge...
Auto-merging content/en/docs/ops/security/root-transition/index.md
CONFLICT (content): Merge conflict in content/en/docs/ops/security/root-transition/index.md
Patch failed at 0001 Improve root transition doc.

@istio-testing
Copy link
Contributor

In response to a cherrypick label: cannot checkout release-1.4: error checking out release-1.4: exit status 1. output: error: pathspec 'release-1.4' did not match any file(s) known to git.

@myidpt myidpt deleted the roottransition branch November 9, 2019 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@duderino duderino Awaiting requested review from duderino

@rcaballeromx rcaballeromx Awaiting requested review from rcaballeromx

2 more reviewers

@geeknoid geeknoid geeknoid approved these changes

@JimmyCYJ JimmyCYJ JimmyCYJ approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area/security cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. kind/docs size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@myidpt @istio-testing @geeknoid @JimmyCYJ @googlebot @istio-policy-bot