Skip to content

Conversation

frankbu
Copy link
Collaborator

@frankbu frankbu commented Nov 7, 2019

No description provided.

@frankbu frankbu requested a review from a team as a code owner November 7, 2019 16:23
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 7, 2019
@istio-testing istio-testing added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 7, 2019
@frankbu frankbu requested a review from a team as a code owner November 7, 2019 17:09
@istio-testing istio-testing added needs-rebase Indicates a PR needs to be rebased before being merged size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 7, 2019
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Nov 7, 2019
@pitlv2109 pitlv2109 requested a review from a team November 7, 2019 18:18
@@ -3,6 +3,8 @@ title: Authorization for groups and list claims
description: Tutorial on how to configure the groups-base authorization and configure the authorization of list-typed claims in Istio.
weight: 4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the weight to 30 so that this page is after the HTTP and TCP task?

@rcaballeromx
Copy link
Contributor

Could we use the following categories instead?

  • Authentication
  • Authorization
  • Encryption
  • Identity

@frankbu
Copy link
Collaborator Author

frankbu commented Nov 7, 2019

@rcaballeromx Not really, because we have no Encryption or Identity tasks, so there would be nothing in them.

@rcaballeromx
Copy link
Contributor

@rcaballeromx Not really, because we have no Encryption or Identity tasks, so there would be nothing in them.

@frankbu The content you have around configuring Citadel is to get those things in place. Or am I missing something?

@frankbu
Copy link
Collaborator Author

frankbu commented Nov 7, 2019

@rcaballeromx The tasks are a mixed bag, all around configuring Citatel. I woudn't really think of them as encryption or identify tasks. I wouldn't really know what to expect in an encryption task section. A task that shows how to change encryption algorithms? I don't think that's even supported.

@frankbu
Copy link
Collaborator Author

frankbu commented Nov 7, 2019

After 1.4, we can consider further refining the categories, but we'll need to rework some of the tasks at the same time.

I think we should merge this as is now, the sooner the better, because it will have merge conflicts with lots of other affected docs.

@rcaballeromx
Copy link
Contributor

@frankbu I think you are right, post release we will revisit. Encryption wouldn't be how to change encryption algorithms but rather how to get traffic in the mesh encrypted.
Let's revisit for 1.5 then.

@frankbu frankbu merged commit a6a5769 into master Nov 7, 2019
@frankbu frankbu deleted the auto-mtls branch November 7, 2019 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants