Skip to content

zh-translation:/docs/ops/architecture/index.md #5469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 8, 2019
Merged

zh-translation:/docs/ops/architecture/index.md #5469

merged 5 commits into from
Nov 8, 2019

Conversation

GuangmingLuo
Copy link
Contributor

@GuangmingLuo GuangmingLuo commented Nov 7, 2019 •
edited by istio-policy-bot
Loading

@GuangmingLuo GuangmingLuo requested a review from a team as a code owner November 7, 2019 13:49
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 7, 2019
@istio-testing istio-testing added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test labels Nov 7, 2019
@istio-testing
Copy link
Contributor

Hi @GuangmingLuo. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rootsongjc rootsongjc added the translation/chinese Translation item label Nov 7, 2019
@rootsongjc
Copy link
Member

Request for a reviewer.

@rootsongjc
Copy link
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Nov 7, 2019
@malphi
Copy link
Contributor

malphi commented Nov 7, 2019

/review

@malphi
Copy link
Contributor

malphi commented Nov 7, 2019

/assign @malphi

1 similar comment
@rootsongjc
Copy link
Member

/assign @malphi

malphi
malphi reviewed Nov 7, 2019
View reviewed changes
malphi
malphi reviewed Nov 7, 2019
View reviewed changes
malphi
malphi reviewed Nov 7, 2019
View reviewed changes
malphi
malphi reviewed Nov 7, 2019
View reviewed changes
malphi
malphi reviewed Nov 7, 2019
View reviewed changes
malphi
malphi reviewed Nov 7, 2019
View reviewed changes
malphi
malphi reviewed Nov 7, 2019
View reviewed changes
malphi
malphi reviewed Nov 7, 2019
View reviewed changes
malphi
malphi reviewed Nov 7, 2019
View reviewed changes
malphi
malphi reviewed Nov 7, 2019
View reviewed changes
malphi
malphi reviewed Nov 7, 2019
View reviewed changes
malphi
malphi reviewed Nov 7, 2019
View reviewed changes
malphi
malphi reviewed Nov 7, 2019
View reviewed changes
malphi
malphi reviewed Nov 7, 2019
View reviewed changes
malphi
malphi reviewed Nov 7, 2019
View reviewed changes
malphi
malphi reviewed Nov 7, 2019
View reviewed changes
malphi
malphi reviewed Nov 7, 2019
View reviewed changes
malphi
malphi reviewed Nov 7, 2019
View reviewed changes
malphi
malphi reviewed Nov 7, 2019
View reviewed changes
rootsongjc
rootsongjc reviewed Nov 8, 2019
View reviewed changes
rootsongjc
rootsongjc reviewed Nov 8, 2019
View reviewed changes
rootsongjc
rootsongjc reviewed Nov 8, 2019
View reviewed changes
@malphi
Copy link
Contributor

malphi commented Nov 8, 2019 •
edited
Loading

/LGTM

rootsongjc
rootsongjc approved these changes Nov 8, 2019
View reviewed changes
Copy link
Member

@rootsongjc rootsongjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@istio-testing istio-testing merged commit 669179d into istio:master Nov 8, 2019
@GuangmingLuo GuangmingLuo deleted the patch-1 branch November 8, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@malphi malphi malphi left review comments

@rootsongjc rootsongjc rootsongjc approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@malphi malphi

Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/chinese Translation item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@GuangmingLuo @istio-testing @rootsongjc @malphi @googlebot