Skip to content

Conversation

Luluda
Copy link
Contributor

@Luluda Luluda commented Nov 7, 2019

标题:
zh-translation: /istio.io/content/zh/boilerplates/index.md
/istio.io/content/zh/boilerplates/helm-security-warning.md
内容:
ref: servicemesher/istio-official-translation#1351
servicemesher/istio-official-translation#1352

@Luluda Luluda requested a review from a team as a code owner November 7, 2019 13:41
@istio-testing istio-testing added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test labels Nov 7, 2019
@istio-testing
Copy link
Contributor

Hi @Luluda. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 7, 2019
@rootsongjc rootsongjc added the translation/chinese Translation item label Nov 7, 2019
See the [Securing your Helm Installation](https://helm.sh/docs/securing_installation/)
for further steps to secure a Tiller-based installation.
{{< /warning >}}
本文档中介绍如何使用带Tiller的Helm不使用安全默认值。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

中英文间要加空格。

for further steps to secure a Tiller-based installation.
{{< /warning >}}
本文档中介绍如何使用带Tiller的Helm不使用安全默认值。
有关基于Tiller安全安装的进一步步骤请参考 [Securing your Helm Installation](https://helm.sh/docs/securing_installation/)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

英文没翻译。
最后没句号。

@rootsongjc rootsongjc self-assigned this Nov 7, 2019
@geeknoid
Copy link
Contributor

geeknoid commented Nov 7, 2019

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Nov 7, 2019
@geeknoid
Copy link
Contributor

geeknoid commented Nov 7, 2019

/ok-to-test

@rootsongjc rootsongjc changed the title zh trans 1351/1352 zh-translation: istio.io/content/zh/boilerplates/index.md Nov 8, 2019
@Luluda
Copy link
Contributor Author

Luluda commented Nov 8, 2019

/retest

for further steps to secure a Tiller-based installation.
{{< /warning >}}
本文档中介绍如何使用带 Tiller 的 Helm 不使用安全默认值。
有关基于 Tiller 安全安装的进一步步骤请参考[安全安装Helm](https://helm.sh/docs/securing_installation/)。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

中英文间要加空格。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是链接那里吗?之前的版本加了空格,lint检查报这个错误了:MD039 Spaces inside link text

Copy link
Member

@rootsongjc rootsongjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@istio-testing istio-testing merged commit e5c5347 into istio:master Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/chinese Translation item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants