Skip to content

zh-translation:/docs/setup/platform-setup/ibm/index.md #5449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2019
Merged

zh-translation:/docs/setup/platform-setup/ibm/index.md #5449

merged 1 commit into from
Nov 7, 2019

Conversation

arunfung
Copy link
Contributor

@arunfung arunfung commented Nov 7, 2019 •
edited by istio-policy-bot
Loading

@arunfung arunfung requested a review from a team as a code owner November 7, 2019 09:13
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 7, 2019
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test labels Nov 7, 2019
@istio-testing
Copy link
Contributor

Hi @arunfung. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rootsongjc rootsongjc added the translation/chinese Translation item label Nov 7, 2019
rootsongjc
rootsongjc reviewed Nov 7, 2019
View reviewed changes
content/zh/docs/setup/platform-setup/ibm/index.md Outdated
title: IBM Cloud
description: Instructions to setup an IBM Cloud cluster for Istio.
title: IBM Cloud 快速开始
description: 在 IBM 公有云或私有云上快速搭建 Istio 服务.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请使用中文句号。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

@rootsongjc rootsongjc self-assigned this Nov 7, 2019
@rootsongjc
Copy link
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Nov 7, 2019
rootsongjc
rootsongjc approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@rootsongjc rootsongjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@istio-testing istio-testing merged commit 2d36dc1 into istio:master Nov 7, 2019
@arunfung arunfung deleted the zh-trans-1296 branch November 8, 2019 03:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rootsongjc rootsongjc rootsongjc approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@rootsongjc rootsongjc

Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/chinese Translation item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@arunfung @istio-testing @rootsongjc @googlebot @istio-policy-bot