Skip to content

zh-translation: content/zh/docs/tasks/traffic-management/ingress/secu… #5333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2019
Merged

zh-translation: content/zh/docs/tasks/traffic-management/ingress/secu… #5333

merged 1 commit into from
Nov 6, 2019

Conversation

wangzewang
Copy link
Contributor

@wangzewang wangzewang commented Nov 4, 2019 •
edited by istio-policy-bot
Loading

@wangzewang wangzewang requested a review from a team as a code owner November 4, 2019 13:28
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 4, 2019
@istio-testing istio-testing added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 4, 2019
@istio-testing
Copy link
Contributor

Hi @wangzewang. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rootsongjc rootsongjc added the translation/chinese Translation item label Nov 4, 2019
rootsongjc
rootsongjc suggested changes Nov 4, 2019
View reviewed changes
Copy link
Member

@rootsongjc rootsongjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need change

@luxious
Copy link
Contributor

luxious commented Nov 5, 2019

/review

@rootsongjc
Copy link
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Nov 5, 2019
@rootsongjc
Copy link
Member

430 files are free from spelling errors
./zh/docs/tasks/traffic-management/ingress/secure-ingress-sds/index.md
69 | ## 使用 SDS 配置 TLS Ingress 网关 {#configure-a-tls-ingress-gateway-using-sds}
1 spelling error found in 429 files
To learn how to address spelling errors, please see https://istio.io/about/contribute/creating-and-editing-pages/#linting
Running ["LinkCheck", "HtmlCheck", "OpenGraphCheck", "ImageCheck", "ScriptCheck"] on ["./public"] on *.html...
Found 0 links in the cache...
Adding 892 links to the cache...
Removing 0 links from the cache...
Checking 892 external links...
Ran on 760 files!

  • ./public/zh/docs/tasks/traffic-management/ingress/secure-ingress-sds/index.html
    • internally linking to zh/docs/tasks/traffic-management/ingress, which does not exist (line 52908)
      控制 Ingress 流量任务
      htmlproofer 3.12.0 | Error: HTML-Proofer found 1 failure!
      LINTING FAILED
      Makefile.core.mk:27: recipe for target 'lint' failed
      make: *** [lint] Error 1

@wangzewang wangzewang force-pushed the zh-trans-1334 branch 2 times, most recently from 72ccd9b to b435da6 Compare November 5, 2019 03:57
gaohuag
gaohuag reviewed Nov 5, 2019
View reviewed changes
Copy link
Contributor

@gaohuag gaohuag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

rootsongjc
rootsongjc suggested changes Nov 5, 2019
View reviewed changes
Copy link
Member

@rootsongjc rootsongjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need change.

luxious
luxious reviewed Nov 6, 2019
View reviewed changes
Copy link
Contributor

@luxious luxious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@wangzewang wangzewang requested a review from rootsongjc November 6, 2019 06:43
rootsongjc
rootsongjc approved these changes Nov 6, 2019
View reviewed changes
Copy link
Member

@rootsongjc rootsongjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@istio-testing istio-testing merged commit 103a29c into istio:master Nov 6, 2019
@wangzewang wangzewang deleted the zh-trans-1334 branch November 6, 2019 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
3 more reviewers

@luxious luxious luxious left review comments

@gaohuag gaohuag gaohuag left review comments

@rootsongjc rootsongjc rootsongjc approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@luxious luxious

Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/chinese Translation item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@wangzewang @istio-testing @luxious @rootsongjc @gaohuag @googlebot @istio-policy-bot