Skip to content

Conversation

huntsman-li
Copy link
Contributor

@huntsman-li huntsman-li requested a review from a team as a code owner November 4, 2019 10:41
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. label Nov 4, 2019
@istio-testing istio-testing added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 4, 2019
@istio-testing
Copy link
Contributor

Hi @huntsman-li. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@huntsman-li
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@rootsongjc rootsongjc added the translation/chinese Translation item label Nov 4, 2019
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. and removed cla: no Set by the Google CLA bot to indicate the author of a PR has not signed the Google CLA. labels Nov 5, 2019
@rootsongjc
Copy link
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Nov 5, 2019
@gaohuag
Copy link
Contributor

gaohuag commented Nov 5, 2019

/review

Copy link
Contributor

@gaohuag gaohuag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update keywords
update 服务帐户机密 => 服务帐户密钥
update 机密 => secerts
update 机密 => secrets
@rootsongjc
Copy link
Member

Headers with anchors lint failed. Can you help us to fix these errors? @geeknoid

430 files are free from spelling errors
./zh/docs/concepts/security/index.md
79 | ### Istio 安全与 SPIFFE{#istio-security-vs-spiffe}
91 | ## PKI{#pki}
100 | ### Kubernetes 方案{#kubernetes-scenario}
122 | ### Kubernetes 中的代理节点{#node-agent-in-kubernetes}
227 | ### 双向 TLS 认证{#mutual-tls-authentication}
460 | #### ServiceRole{#servicerole}
538 | #### ServiceRoleBinding{#servicerolebinding}
602 | ### 在普通 TCP 协议上使用 Istio 认证{#using-istio-authorization-on-plain-tcp-protocols}
8 spelling errors found in 429 files
To learn how to address spelling errors, please see https://istio.io/about/contribute/creating-and-editing-pages/#linting
Running ["LinkCheck", "HtmlCheck", "OpenGraphCheck", "ImageCheck", "ScriptCheck"] on ["./public"] on *.html...

@geeknoid
Copy link
Contributor

geeknoid commented Nov 5, 2019

I guess the spell checker treats the fragment name as normal text and insists it be valid. So to fix this, you need to use words from the dictionary:

  • kubernetes should be Kubernetes
  • servicerole should be service-role
  • servicerolebinding should be service-role-binding
  • tcp -> TCP
  • tls -> TLS

@huntsman-li huntsman-li requested a review from a team as a code owner November 6, 2019 01:38
@istio-testing istio-testing added the needs-rebase Indicates a PR needs to be rebased before being merged label Nov 6, 2019
@istio-testing istio-testing removed the needs-rebase Indicates a PR needs to be rebased before being merged label Nov 6, 2019
update /docs/reference/config/policy-and-telemetry/
mutual-tls-authentication => mutual-TLS-authentication
服务到服务 => 服务间, 数据、端点、通信
秘密 => secret
有关使用安全功能的详细说明 => 以获取有关使用安全功能的详细说明
名称空间 => 命名空间
Copy link
Member

@rootsongjc rootsongjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@istio-testing istio-testing merged commit e8bd3b7 into istio:master Nov 6, 2019
@huntsman-li huntsman-li deleted the zh-trans-1052 branch November 7, 2019 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/chinese Translation item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants