Skip to content

zh-translation: /docs/tasks/security/plugin-ca-cert/index.md #5399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Nov 7, 2019
Merged

zh-translation: /docs/tasks/security/plugin-ca-cert/index.md #5399

merged 21 commits into from
Nov 7, 2019

Conversation

gaohuag
Copy link
Contributor

@gaohuag gaohuag commented Nov 6, 2019 •
edited by istio-policy-bot
Loading

标题：
zh-translation:content/zh/docs/tasks/security/plugin-ca-cert/index.md
内容：
ref: servicemesher/istio-official-translation#1388

@gaohuag gaohuag requested a review from a team as a code owner November 6, 2019 03:36
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 6, 2019
@istio-testing istio-testing added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test labels Nov 6, 2019
@istio-testing
Copy link
Contributor

Hi @gaohuag. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rootsongjc rootsongjc added the translation/chinese Translation item label Nov 6, 2019
rootsongjc
rootsongjc reviewed Nov 6, 2019
View reviewed changes
content/zh/docs/tasks/security/plugin-ca-cert/index.md Outdated
{{< /tip >}}

## Plugging in the existing certificate and key
## 插入现有密钥和证书
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

文中所有标题都需要补充锚点。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rootsongjc 改好了

@rootsongjc
Copy link
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Nov 6, 2019
@gaohuag
Copy link
Contributor Author

gaohuag commented Nov 7, 2019

@rootsongjc 请求审查 :)

rootsongjc
rootsongjc reviewed Nov 7, 2019
View reviewed changes
content/zh/docs/tasks/security/plugin-ca-cert/index.md Outdated

{{< text bash >}}
$ kubectl delete secret cacerts -n istio-system
{{< /text >}}

* To remove the Istio components: follow the [uninstall instructions](/docs/setup/install/kubernetes/#uninstall) to remove.

* 移除 Istio 组件：按照 [uninstall instructions](/zh/docs/setup/install/kubernetes/#uninstall) 进行删除。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

uninstall instructions 没有翻译，文中还有些链接字段没有翻译。

rootsongjc
rootsongjc suggested changes Nov 7, 2019
View reviewed changes
Copy link
Member

@rootsongjc rootsongjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

需要修改。

@rootsongjc rootsongjc self-assigned this Nov 7, 2019
@gaohuag
Copy link
Contributor Author

gaohuag commented Nov 7, 2019

需要修改。

好的

@gaohuag
Copy link
Contributor Author

gaohuag commented Nov 7, 2019

改好了 @rootsongjc

rootsongjc
rootsongjc reviewed Nov 7, 2019
View reviewed changes
rootsongjc
rootsongjc approved these changes Nov 7, 2019
View reviewed changes
Copy link
Member

@rootsongjc rootsongjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@istio-testing istio-testing merged commit 1d06bc1 into istio:master Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rootsongjc rootsongjc rootsongjc approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@rootsongjc rootsongjc

Labels
area/security cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/chinese Translation item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gaohuag @istio-testing @rootsongjc @googlebot @istio-policy-bot