Skip to content

Conversation

sunny0826
Copy link
Contributor

@sunny0826 sunny0826 commented Nov 6, 2019

@sunny0826 sunny0826 requested a review from a team as a code owner November 6, 2019 02:04
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 6, 2019
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test labels Nov 6, 2019
@istio-testing
Copy link
Contributor

Hi @sunny0826. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rootsongjc rootsongjc added the translation/chinese Translation item label Nov 6, 2019
@rootsongjc
Copy link
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Nov 6, 2019
@rootsongjc rootsongjc self-assigned this Nov 6, 2019
- **修复** 入站侦听器重载间隔调整为 5 分钟。([Issue #18138](https://github.com/istio/istio/issues/18088))
- **修复** 密钥验证和证书轮换。([Issue #17718](https://github.com/istio/istio/issues/17718))
- **修复** 内部资源垃圾回收无效问题。([Issue #16818](https://github.com/istio/istio/issues/16818))
- **修复** 了当失败时 webhook 更新失败的问题。([Pull Request #17820](https://github.com/istio/istio/pull/17820)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

失败 -> 故障

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

已修改

Copy link
Member

@rootsongjc rootsongjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@istio-testing istio-testing merged commit 383a0a1 into istio:master Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. kind/docs ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/chinese Translation item
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants