Skip to content

zh-translation:/docs/ops/setup/validation/index.md #5354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Nov 5, 2019
Merged

zh-translation:/docs/ops/setup/validation/index.md #5354

merged 8 commits into from
Nov 5, 2019

Conversation

Lovnx
Copy link
Contributor

@Lovnx Lovnx commented Nov 5, 2019

@Lovnx Lovnx requested a review from a team as a code owner November 5, 2019 02:28
@googlebot googlebot added the cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. label Nov 5, 2019
@istio-testing istio-testing added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test labels Nov 5, 2019
@istio-testing
Copy link
Contributor

Hi @Lovnx. Thanks for your PR.

I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rootsongjc rootsongjc added the translation/chinese Translation item label Nov 5, 2019
rootsongjc
rootsongjc reviewed Nov 5, 2019
View reviewed changes
content/zh/docs/ops/setup/validation/index.md Outdated
@@ -1,25 +1,15 @@
---
title: Configuration Validation Webhook
description: Describes Istio's use of Kubernetes webhooks for server-side configuration validation.
description: 描述 Istio 使用 Kubernetes webhooks 来进行服务端配置。
weight: 20
aliases:
- /help/ops/setup/validation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

请增加 /zh 前缀。

rootsongjc
rootsongjc reviewed Nov 5, 2019
View reviewed changes
content/zh/docs/ops/setup/validation/index.md Outdated
@@ -3,7 +3,7 @@ title: Configuration Validation Webhook
description: 描述 Istio 使用 Kubernetes webhooks 来进行服务端配置。
weight: 20
aliases:
- /help/ops/setup/validation
- /zh/docs/ops/setup/validation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

只要在原路径的基础上加上 /zh 前缀即可，不要再加 docs。

rootsongjc
rootsongjc reviewed Nov 5, 2019
View reviewed changes
content/zh/docs/ops/setup/validation/index.md Outdated
@@ -3,7 +3,7 @@ title: Configuration Validation Webhook
description: 描述 Istio 使用 Kubernetes webhooks 来进行服务端配置。
weight: 20
aliases:
- /help/ops/setup/validation
- /zh/docs/ops/setup/validation
---

Galley 的配置验证可确保用户编写的 Istio 配置在语法和语义上均有效。它使用了 Kubernetes 的 `ValidatingWebhook`。`istio-galley` 的 `ValidatingWebhookConfiguration` 配置有两个 webhooks 。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webhook 不需要使用复数。

rootsongjc
rootsongjc suggested changes Nov 5, 2019
View reviewed changes
Copy link
Member

@rootsongjc rootsongjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need change.

@rootsongjc rootsongjc self-assigned this Nov 5, 2019
rootsongjc
rootsongjc reviewed Nov 5, 2019
View reviewed changes
content/zh/docs/ops/setup/validation/index.md Outdated
responsible for validating configuration consumed by Mixer.
* `mixer.validation.istio.io` - 它通过 `/admitmixer` 路径提供服务，并负责验证 Mixer 使用的配置。

这两个 webhooks 都经 `istio-galley` 在443端口提供服务， 每个 webhook 都有自己的 `clientConfig`、`namespaceSelector`和 `rules` 部分，作用于所有命名空间，其中`namespaceSelector` 应该为空， 所有 `rules` 都适用于 Istio Custom Resource Definitions (CRDs)。
Copy link
Member

@rootsongjc rootsongjc Nov 5, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

数字跟文字之间需要加空格。CRDs -> CRD

rootsongjc
rootsongjc suggested changes Nov 5, 2019
View reviewed changes
Copy link
Member

@rootsongjc rootsongjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need changes.

rootsongjc
rootsongjc reviewed Nov 5, 2019
View reviewed changes
content/zh/docs/ops/setup/validation/index.md Outdated
@@ -12,5 +12,5 @@ Galley 的配置验证可确保用户编写的 Istio 配置在语法和语义上

* `mixer.validation.istio.io` - 它通过 `/admitmixer` 路径提供服务，并负责验证 Mixer 使用的配置。

这两个 webhooks 都经 `istio-galley` 在 443 端口提供服务， 每个 webhook 都有自己的 `clientConfig`、`namespaceSelector`和 `rules` 部分，作用于所有命名空间，其中`namespaceSelector` 应该为空， 所有 `rules` 都适用于 Istio Custom Resource Definitions (CRDs)。
这两个 webhooks 都经 `istio-galley` 在 443 端口提供服务， 每个 webhook 都有自己的 `clientConfig`、`namespaceSelector`和 `rules` 部分，作用于所有命名空间，其中`namespaceSelector` 应该为空， 所有 `rules` 都适用于 Istio Custom Resource Definitions (CRD)。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

中英文之间请加空格。

rootsongjc
rootsongjc reviewed Nov 5, 2019
View reviewed changes
content/zh/docs/ops/setup/validation/index.md Outdated
@@ -12,5 +12,5 @@ Galley 的配置验证可确保用户编写的 Istio 配置在语法和语义上

* `mixer.validation.istio.io` - 它通过 `/admitmixer` 路径提供服务，并负责验证 Mixer 使用的配置。

这两个 webhooks 都经 `istio-galley` 在 443 端口提供服务， 每个 webhook 都有自己的 `clientConfig`、`namespaceSelector`和 `rules` 部分，作用于所有命名空间，其中`namespaceSelector` 应该为空， 所有 `rules` 都适用于 Istio Custom Resource Definitions (CRD)。
这两个 webhooks 都经 `istio-galley` 在 443 端口提供服务， 每个 webhook 都有自己的 `clientConfig`、`namespaceSelector` 和 `rules` 部分，作用于所有命名空间，其中 `namespaceSelector` 应该为空， 所有 `rules` 都适用于 Istio Custom Resource Definitions (CRD)。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webhook 改用单数。

@rootsongjc
Copy link
Member

/ok-to-test

@istio-testing istio-testing added ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. and removed needs-ok-to-test labels Nov 5, 2019
@rootsongjc
Copy link
Member

/ok-to-test

rootsongjc
rootsongjc approved these changes Nov 5, 2019
View reviewed changes
Copy link
Member

@rootsongjc rootsongjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@istio-testing istio-testing merged commit 89bd513 into istio:master Nov 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@rootsongjc rootsongjc rootsongjc approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@rootsongjc rootsongjc

Labels
cla: yes Set by the Google CLA bot to indicate the author of a PR has signed the Google CLA. ok-to-test Set this label allow normal testing to take place for a PR not submitted by an Istio org member. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/chinese Translation item
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Lovnx @istio-testing @rootsongjc @googlebot