Skip to content

Conversation

gyliu513
Copy link
Member

@gyliu513 gyliu513 commented Jun 4, 2018

/cc @linsun

@istio-testing istio-testing requested a review from linsun June 4, 2018 09:25
@istio-testing
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gyliu513
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: geeknoid

Assign the PR to them by writing /assign @geeknoid in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linsun linsun merged commit 3cf6f48 into istio:master Jun 4, 2018
geeknoid pushed a commit that referenced this pull request Jun 4, 2018
@gyliu513 gyliu513 deleted the iks branch June 4, 2018 13:57
ayj pushed a commit to ayj/istio.github.io that referenced this pull request Jun 9, 2018
3ks added a commit to 3ks/istio.io that referenced this pull request Nov 4, 2019
3ks added a commit to 3ks/istio.io that referenced this pull request Nov 4, 2019
istio-testing pushed a commit that referenced this pull request Nov 5, 2019
* zh-translation: /faq/setup/index.md (#1081)

* zh-translation: /faq/setup/k8s-migrating.md (#1434)

* zh-translation: /faq/setup/consul-unset-context.md (#1432)

* zh-translation: /faq/setup/k8s-migrating.md (#1434)

* zh-translation: /faq/setup/consul-unset-context.md (#1432)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants