Skip to content

remove --debug as it is deprecated #1427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

remove --debug as it is deprecated #1427

wants to merge 1 commit into from

Conversation

linsun
Copy link
Member

@linsun linsun commented Jun 4, 2018

No description provided.

@istio-testing
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: linsun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linsun linsun requested review from gyliu513 and ymesika June 4, 2018 02:46
gyliu513
gyliu513 reviewed Jun 4, 2018
View reviewed changes
Copy link
Member

@gyliu513 gyliu513 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@linsun do you want to do a swipe for the whole document, I found that there are many places are still using --debug.

I found that istio-proxy now has curl by default, so we do not need --debug now, can you please show me the link where this issue got fixed? Would be great if you put some detail for the deprecation in commit message. Thanks. ;-)

@ymesika
Copy link
Member

ymesika commented Jun 4, 2018

There are several more docs with the --debug flag. I think they should be updated too in this PR.
It is both deprecated and there is no proxyv2 debug image at the moment so it's just useless flag in 0.8.

@gyliu513 gyliu513 mentioned this pull request Jun 5, 2018
Closed
@istio-testing
Copy link
Contributor

@linsun: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@geeknoid
Copy link
Contributor

geeknoid commented Jun 6, 2018

This change was already applied by another PR.

@geeknoid geeknoid closed this Jun 6, 2018
@geeknoid geeknoid deleted the linsun-patch-6 branch June 15, 2018 15:42
3ks added a commit to 3ks/istio.io that referenced this pull request Nov 5, 2019
@3ks
zh-translation: /faq/security/non-istio-to-istio.md (istio#1427)
31979d0
3ks added a commit to 3ks/istio.io that referenced this pull request Nov 6, 2019
@3ks
zh-translation: /faq/security/non-istio-to-istio.md (istio#1427)
78ec545
3ks added a commit to 3ks/istio.io that referenced this pull request Nov 6, 2019
@3ks
zh-translation: /faq/security/non-istio-to-istio.md (istio#1427)
ff971ba
istio-testing pushed a commit that referenced this pull request Nov 6, 2019
@3ks @istio-testing
zh-translation: /faq/security (#5400)
60ec9aa 
* zh-translation: /faq/security/auth-mix-and-match.md (#1422)

* zh-translation: /faq/security/non-istio-to-istio.md (#1427)

* zh-translation: /faq/security: not translate namespace

* zh-tran-security: /docs/concepts/security/index.md : fix anchor
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymesika ymesika Awaiting requested review from ymesika

1 more reviewer

@gyliu513 gyliu513 gyliu513 left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@linsun @istio-testing @ymesika @geeknoid @gyliu513 @googlebot