-
Notifications
You must be signed in to change notification settings - Fork 1.6k
clarify unmentioned constraint port.name equalness (cherry-pick #11680) #11891
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hi @tedli. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
If we don't want to push #11680, then let's merge this and cherry-pick to 1.15 (already labelled). Since @craigbox had the latest review, I'll leave this for him to approve. |
@craigbox Any further comments on this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add comments from #11892.
…#11680) (istio#11891) * doc the port name should be same * namespace sameness, accept craigbox's suggestion
Please provide a description for what this PR is for.
cherry-pick #11680
In our multi cluster mesh, we found that, even we meet the
namespace-sameness
, cross cluster calls to remote cluster through eastwest gateway never happen in some cases. (calls always invoke to primary cluster)After some digging, we found that the
same
kubernetesService
had differentport.name
, and the code that aggregating eds reads the port.name to match endpoint with service.And if we correct the
Service.spec.ports[_].name
to be same as what in primary cluster (literally equal, both name no specified consider equal "" == "" ), cross cluster calls act as expect.So as
namespace-sameness
, the addition constraint should be documented.https://github.com/istio/istio/blob/93e4ec424b52da807228bd7784c59d646ec73733/pilot/pkg/xds/endpoint_builder.go#L240-L242
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.