Feature aws nlb #1162
Feature aws nlb #1162
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: Assign the PR to them by writing The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Hi @jsenon. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
_docs/setup/kubernetes/aws-nlb.md
Outdated
|
|
||
| ## Prerequisites | ||
| The following instructions require you have access to a Kubernetes **1.9.0 or newer** cluster | ||
| *Warning:* This is an alpha feature and not recommended for production clusters yet. |
There was a problem hiding this comment.
In a previous reviews related to adding features, I was nudged away from providing indications of suitability for dev/alpha/beta/stable feature stages. If you do want to provide such a warning, have a look at the icon here: https://github.com/istio/istio.github.io/blame/master/_docs/setup/kubernetes/quick-start-gke-dm.md#L26
In addition, the adverb yet is redundant.
_docs/setup/kubernetes/aws-nlb.md
Outdated
| title: AWS NLB | ||
| overview: Instructions to use and configure ingress istio with aws NLB. | ||
|
|
||
| order: 12 |
There was a problem hiding this comment.
order doesn't look correct. Could you use a higher number? Typically newer features go towards the end of the Kubernetes quickstart, but I'm not sure there is a specific policy on ordering. Rendering the landing page and attaching a screen shot may help 👍
| } | ||
| ``` | ||
|
|
||
| ## Rewrite Istio Ingress Service |
There was a problem hiding this comment.
I think this section will make this document hard to maintain and keep people from trying this work out.
If you do take the approach in this document, I'd recommend a blog post.
Another approach is to integrate into the main helm chart here:
https://github.com/istio/istio/blob/master/install/kubernetes/helm/istio/charts/ingress/templates/service.yaml
Keep in mind the network WG is rapidly working on a new ingress/egress model (called ingressgateway and egressgateway). I am not up to speed on the plans of that work.
|
@sdake thanks for your remarks. You right for blog page, does istio have a blog post where contributors can post? (like kubernetes blog) |
|
@jsenon I am not familiar with the Kubernetes public blog, so I don't know if its like the Istio public blog. The Istio blog is published on istio.io under https://istio.io/blog. To publish to this blog, submit the file under https://github.com/istio/istio.github.io/tree/master/_blog. These render much like the quickstarts. Cheers |
|
I think you right @sdake , I've submitted an entry in blog instead of install documentation |
|
/close |
I propose a guide to deploy istio ingress with aws network load balancer