Fix broken SVGs #1027
Fix broken SVGs #1027
Conversation
Signed-off-by: Dan Kohn <dan@dankohn.com>
|
cc @geeknoid |
|
In what way were the SVG files corrupted? The front-matter was intentionally added so that the SVG gets compressed before being emitted in the main site. In usage, as far as I can tell, these SVGs were fine and being loaded by browsers. Did the compression mess something up that browsers just overlook? |
|
ah glad it didn't break on the site, but that header makes them uneditable |
|
It's good hygiene to statically compressed everything. I agree that it
doesn't make much of a difference for those small files, but I rather just
do it systematically for all our site content. All .html files in the site
are also 'broken' in that respect since they're not valid HTML file until
the site is published.
…On Sat, Feb 24, 2018 at 9:57 AM Laurent Demailly ***@***.***> wrote:
ah glad it didn't break on the site, but that header makes them uneditable
also I don't think compression for a 3k long cached file is really that
important ? it should be done by the webserver config if we needed
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1027 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AVucHRU_ARh2qdHilMWgNoU2hkNYUdj_ks5tYE2RgaJpZM4SRz-J>
.
|
|
most (all?) the human editable content is in MD / jekyll format, not plain html (yes lots of html fragments too) but more relevant: you can't exactly draw in text mode when opening the files; if one needed to edit the icons (yes I have a couple hand coded svg too but that's not quite the common case) |
|
It breaks them in the SVG viewer on GitHub.
--
Dan Kohn <dan@linuxfoundation.org>
Executive Director, Cloud Native Computing Foundation https://www.cncf.io
+1-415-233-1000 https://www.dankohn.com
… On Feb 25, 2018, at 01:45, Martin Taillefer ***@***.***> wrote:
In what way were the SVG files corrupted?
The front-matter was intentionally added so that the SVG gets compressed before being emitted in the main site. In usage, as far as I can tell, these SVGs were fine and being loaded by browsers.
Did the compression mess something up that browsers just overlook?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Signed-off-by: Dan Kohn dan@dankohn.com
All of these SVGs were corrupted.