Skip to content

Fix remarks of a technical writer regarding the TCP egress task and blog post #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 39 commits into from
Feb 23, 2018
Merged

Fix remarks of a technical writer regarding the TCP egress task and blog post #1026

merged 39 commits into from
Feb 23, 2018

Conversation

vadimeisenbergibm
Copy link
Contributor

No description provided.

@vadimeisenbergibm
To remind -> a quick reminder
b6a733b
@vadimeisenbergibm
would do -> good enough, make "Note" bold
cac32c0
@vadimeisenbergibm
a single rule -> just a single rule
44b7419
@vadimeisenbergibm
It is -> This is
3684a80
@vadimeisenbergibm
see that -> verify that
7e2ce2f
@vadimeisenbergibm
articles in English language -> the articles available on Wikipedia i…
a0e22f7 
…n the English language
@vadimeisenbergibm
remove redundant verbs "will"
4ee6be5
@vadimeisenbergibm
Any MySQL instance would do -> You can use any MySQL instance
e210349
@vadimeisenbergibm
Reversed sentence: As a MySQL client to feed the ratings data, I use …
1a80836 
…mysqlsh MySQL Shell.
@vadimeisenbergibm
Then I -> I then
860d5e4
@vadimeisenbergibm
It means -> This means
c30dd85
@vadimeisenbergibm
reversed the order of "for Bookinfo application I create a special user"
893b184
@vadimeisenbergibm
extract the sentence about the SELECT privilege
835025b
@vadimeisenbergibm
I do not -> I don't
1240cd4
@vadimeisenbergibm
If I would use mysql, I would remove -> If I'm using use mysql, I'll …
ceadd2e 
…remove
@vadimeisenbergibm
Istio Bookinfo sample application -> the Istio Bookinfo sample applic…
7fcba55 
…ation
@vadimeisenbergibm
per each review -> for each review
cf940a3
@vadimeisenbergibm
make original and application lower case in "The original Bookinfo ap…
940b6c6 
…plication"
@vadimeisenbergibm
added a comma before "and password"
1c940c3
@vadimeisenbergibm
No need to mention -> I also assume everyone realizes
ddc986d
@vadimeisenbergibm
removed a comma after "I route all the traffic destined to the _revie…
e6b9bef 
…ws_ service"
@vadimeisenbergibm
Bookinfo Application -> Bookinfo application
12faeed
@vadimeisenbergibm
rephrase the sentence about the error message about ratings service
b8fbc94
@vadimeisenbergibm
added a comma between "the details and the reviews", before "and"
a42cad4
@vadimeisenbergibm
put "let's call it egress-rule-mysql.yaml" into parenthesis instead…
1b9c545 
… of commas
@vadimeisenbergibm
make "Egress Rules" lower case
b372787
@vadimeisenbergibm
the both -> both
6f045b6
@vadimeisenbergibm
rephrased the sentence about the visual cue
7c21568
@vadimeisenbergibm
for example database specific protocols -> such as database-specific …
3f308b7 
…protocols like
@vadimeisenbergibm
CLient -> Client (erroneous upper-case of the second letter)
f87c911
@ldemailly ldemailly merged commit 17851e8 into istio:master Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frankbu frankbu Awaiting requested review from frankbu

2 more reviewers

@ldemailly ldemailly ldemailly approved these changes

@geeknoid geeknoid geeknoid approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vadimeisenbergibm @ldemailly @geeknoid