Skip to content

New format for FAQ, allowing for deep links to answers and making it easier to browse. #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2018
Merged

New format for FAQ, allowing for deep links to answers and making it easier to browse. #1013

merged 1 commit into from
Feb 19, 2018

Conversation

geeknoid
Copy link
Contributor

@geeknoid geeknoid commented Feb 18, 2018 •
edited
Loading

@geeknoid geeknoid requested a review from ZackButcher February 18, 2018 20:18
ldemailly
ldemailly approved these changes Feb 19, 2018
View reviewed changes
Copy link
Member

@ldemailly ldemailly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

woot ! thanks ! this is awesome !
(haven't looked at the implementation, but the staging sold me)

@geeknoid geeknoid merged commit e42f7ed into istio:master Feb 19, 2018
@geeknoid geeknoid deleted the faq branch February 19, 2018 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZackButcher ZackButcher Awaiting requested review from ZackButcher

1 more reviewer

@ldemailly ldemailly ldemailly approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geeknoid @ldemailly