A few fixes #1007
Merged
A few fixes #1007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add support for showing the archive date in the footer. - Fix invalid HTML in the header which improves the responsive layout. In particular, the down arrow for the dropdown menu tends to stay on the same line as the cog more than before. - Tone down the blue color of links so it's not so intense. There's still good contrast between links and normal text. - Remove broken og:image meta tag from each page. It used to point to a logo.png file, which we deleted months ago. Turns out it's not intended for web site logos anyway. - Add og:url and og:site_name per best practices. - Remove one more stray border on the community page. I thought I got rid of 'em last time, but I missed one.
ldemailly
approved these changes
Feb 18, 2018
| @@ -9,7 +9,7 @@ $backgroundColor: $white; | |||
| $textColor: #535f61; | |||
| $textCodeColor: #d14; | |||
|
|
|||
| $linkColor: #469BFF; | |||
| $linkColor: #469Bdd; | |||
There was a problem hiding this comment.
I'd go a bit darker/further to what it used to be but thanks for going in that direction already !
This was referenced Feb 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for showing the archive date in the footer.
Fix invalid HTML in the header which improves the responsive layout. In particular, the down arrow
for the dropdown menu tends to stay on the same line as the cog more than before.
Tone down the blue color of links so it's not so intense. There's still good contrast
between links and normal text.
Remove broken og:image meta tag from each page. It used to point to a logo.png
file, which we deleted months ago. Turns out it's not intended for web site logos
anyway.
Add og:url and og:site_name per best practices.
Remove one more stray border on the community page. I thought I got rid of 'em last time,
but I missed one.
Staging: https://geeknoid.github.io/istio.github.io/