Document EnvoyProxy priority problem #10935
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericvn
reviewed
Feb 17, 2022
| chain of the sidecars. | ||
|
|
||
| To avoid this issue, you can either change the operation to one that does not depend on the presence of | ||
| another filter (e.g., `INSTERT_FIRST`), or set an exlicit priority in the `EnvoyFilter` to override the |
There was a problem hiding this comment.
Suggested change
| another filter (e.g., `INSTERT_FIRST`), or set an exlicit priority in the `EnvoyFilter` to override the | |
| another filter (e.g., `INSERT_FIRST`), or set an exlicit priority in the `EnvoyFilter` to override the |
|
|
||
| To avoid this issue, you can either change the operation to one that does not depend on the presence of | ||
| another filter (e.g., `INSTERT_FIRST`), or set an exlicit priority in the `EnvoyFilter` to override the | ||
| default creation time-based ordering. For example, adding `priorty: 10` to the above filter will ensure |
There was a problem hiding this comment.
Suggested change
| default creation time-based ordering. For example, adding `priorty: 10` to the above filter will ensure | |
| default creation time-based ordering. For example, adding `priority: 10` to the above filter will ensure |
howardjohn
approved these changes
Feb 17, 2022
| error log to indicate that this filter has not been added to the chain. | ||
|
|
||
| This is particularly problematic when matching telemetry filters, like `istio.stats`, because they are version | ||
| specific (i.e., they include the `proxyVersion` field in their match criteria) and therefore will be replaced |
There was a problem hiding this comment.
just a heads up this will change in the future
|
/test doc.test.profile_default_istio.io |
craigbox
requested changes
Feb 23, 2022
| @@ -619,3 +619,41 @@ Most cloud load balancers will not forward the SNI, so if you are terminating TL | |||
| - Disable SNI matching in the `Gateway` by setting the hosts field to `*` | |||
|
|
|||
| A common symptom of this is for the load balancer health checks to succeed while real traffic fails. | |||
|
|
|||
| ## Unchanged envoy filter configuration suddenly stops working | |||
There was a problem hiding this comment.
"Envoy filter" or "EnvoyFilter"
craigbox
approved these changes
Feb 23, 2022
|
/retest |
|
/test doc.test.profile_demo_istio.io |
|
In response to a cherrypick label: new pull request created: #10967 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please provide a description for what this PR is for.
And to help us figure out who should review this PR, please
put an X in all the areas that this PR affects.