Skip to content

Conversation

debianmaster
Copy link
Contributor

for istio on openshift , workloads/addons needed additional permissions to run istio pods with uid 0
due to changes in istio latest release service account names are changed as follows
istio-grafana-service-account to grafana
istio-prometheus-service-account to prometheus

This commit updates openshift related setup steps to latest service account names.

also by default openshift denies privileged containers which is needed as part of sidecar deployment, hence to bypass that error.
oc adm policy add-scc-to-user privileged -z default -n <target-namespace>

@geeknoid geeknoid requested a review from linsun April 2, 2018 14:20
@linsun
Copy link
Member

linsun commented May 8, 2018

/lgtm

@geeknoid
Copy link
Contributor

@debianmaster @linsun Could you resolve the merge conflicts so we can push this PR in?

Thanks.

@debianmaster
Copy link
Contributor Author

debianmaster commented May 10, 2018 via email

@debianmaster
Copy link
Contributor Author

@geeknoid @@linsun i have resolved conflicts. can you take a look and merge if everything looks good.

$ oc adm policy add-scc-to-user anyuid -z prometheus -n istio-system
```

```bash
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use command instead of bash, and put a $ in front of each command-line.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure.

Service account that runs application pods need privileged security context constraints as part of sidecar injection.

```command
$ oc adm policy add-scc-to-user privileged -z default -n <target-namespace>
```

Note:- Check for selinux [discussion](https://github.com/istio/issues/issues/34) w.r.t istio in case you see issues bringing up envoy sidecar.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

istio -> Istio
w.r.t -> with respect to
bringing up envoy -> bringing up the Envoy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, i will keep this in mind for next time.

@linsun
Copy link
Member

linsun commented May 16, 2018

Please ping when all comments are resolved. thanks.

Copy link
Contributor Author

@debianmaster debianmaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issues should be fixed now.

@debianmaster
Copy link
Contributor Author

@linsun can you please verify now. test failed on selinux spelling. i guess that should be ok.

@debianmaster
Copy link
Contributor Author

@linsun gentle reminder

@linsun
Copy link
Member

linsun commented May 17, 2018

/lgtm

@istio-testing
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: debianmaster, linsun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@linsun
Copy link
Member

linsun commented May 17, 2018

can you check why test failed in circle?

@linsun
Copy link
Member

linsun commented May 17, 2018

also update branch :)

@istio-testing istio-testing merged commit 77552f9 into istio:master May 17, 2018
3ks added a commit to 3ks/istio.io that referenced this pull request Dec 4, 2019
3ks added a commit to 3ks/istio.io that referenced this pull request Dec 4, 2019
istio-testing pushed a commit that referenced this pull request Dec 4, 2019
* zh-translation: /blog/2018/egress-monitoring-access-control (#1024)

* fix path

* fix path for blog

* fix path for metrics

* fix path

* add anchor

* fix anchor

* delayering-istio (#1034)

* incremental-traffic-management  (#1101)

* fix error

* fix anchor

* traffix (#1056)

* routing (#1080)

* twitch (#1084)

* aws-nlb (#1085)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants